Re: [eclipselink-dev] Bug 438871

[Rick Curtis <curtisr7@xxxxxxxxx>]

I attached a proposed change and a test case. Can I have someone review it for me?

Thanks,

Rick

On Fri, Jan 9, 2015 at 9:03 AM, andrei ilitchev <andrei.ilitchev@xxxxxxxxxx> wrote:

On 1/9/2015 9:44 AM, Rick Curtis wrote:

> Why semicolons should be there?

Because it is a part of the sql spec.

> Currently I can copy the generated text into sqlPlus and execute it

Interesting that it doesn't work with sqlPlus. From my reading this morning it sounds like it *should* work.

My bad, I didn't work for me in Oracle enterprise manager, not sqlPlus.

On Thu, Jan 8, 2015 at 3:45 PM, andrei ilitchev <andrei.ilitchev@xxxxxxxxxx> wrote:

Why semicolons should be there?
Currently I can copy the generated text into sqlPlus and execute it, with semicolons added I would need to remove them first.
There probably other usages that would be broken, too.

Thanks,
Andrei

On 1/8/2015 4:37 PM, Rick Curtis wrote:

Anyone have anything? 

If not, does this seem like a reasonable change?

On Wed, Jan 7, 2015 at 5:07 PM, Rick Curtis <curtisr7@xxxxxxxxx> wrote:

Is there a particular reason why semicolons aren't appended to the end of generated DDL statements? Is this a default that could safely be changed, or is a new ddl generation property required?

Thanks,

Rick

--

Rick Curtis

--

Rick Curtis

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

--

Rick Curtis

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

--

Rick Curtis