| Re: [eclipselink-dev] bug 330990 - run WDF tests on Derby - ok |
|
Adrian, The patch looks good - I would check it in. - the refactor out of setNullFromDatabaseField() from setParameterValueInDatabaseCall() in core so the platform can override the function is ok and unchanged - For DerbyPlatform changes, I am only slightly worried a bit about backwards compatibility - but this fixes a general non-versioned blocking issue so I think all versions need it - ok - the wdf testing change to check for the DerbyPlatform is ok I am still running before/apply-patch/after testing and will let you know if there are any results issues. Otherwise I would check it in as long as the [test-core] does not only hang with the patch applied (and will also hang in a clean view) Note: I can't find test-core-lrg or test-jpa-lrg targets at trunk or below. I am using test-wdf, test-core and test-jpa I am having unrelated issues in a clean view mostly with TMP_* ddl-gen, my [test-jpa] and [test-core] target which normally pass with 0,0 on Oracle and DB2 also fail (I don't usually trust the lrg results on Derby except for individual tests as Derby does not support everything) - I'll check my driver. >ant test-wdf Tests Failures Errors Success rate Time 828 4 368 55.07% 196.430 Name Tests Errors Failures Time(s) Time Stamp Host org.eclipse.persistence.testing.tests.wdf.jpa1.embedded 5 0 0 21.210 2010-11-25T16:26:26 xps435 org.eclipse.persistence.testing.tests.wdf.jpa1.entitymanager 135 35 0 70.600 2010-11-25T16:26:47 xps435 org.eclipse.persistence.testing.tests.wdf.jpa1.foreignkeys 8 3 4 1.290 2010-11-25T16:27:58 xps435 org.eclipse.persistence.testing.tests.wdf.jpa1.generator 14 4 0 2.080 2010-11-25T16:27:59 xps435 org.eclipse.persistence.testing.tests.wdf.jpa1.inheritance 12 6 0 2.320 2010-11-25T16:28:01 xps435 org.eclipse.persistence.testing.tests.wdf.jpa1.lock 25 0 0 3.450 2010-11-25T16:28:04 xps435 org.eclipse.persistence.testing.tests.wdf.jpa1.mapping 3 1 0 0.520 2010-11-25T16:28:07 xps435 org.eclipse.persistence.testing.tests.wdf.jpa1.query 475 218 0 66.100 2010-11-25T16:28:08 xps435 org.eclipse.persistence.testing.tests.wdf.jpa1.relation 50 43 0 10.680 2010-11-25T16:29:14 xps435 org.eclipse.persistence.testing.tests.wdf.jpa1.simple 94 58 0 16.420 2010-11-25T16:29:25 xps435 org.eclipse.persistence.testing.tests.wdf.jpa2.embeddable 7 0 0 1.760 2010-11-25T16:29:41 xps435 thank you /michael Michael O'Brien wrote: Adrian, |