Re: [eclipselink-dev] BUILD STATUS:: trunk cb build has test failures! -

["Michael O'Brien" <michael.obrien@xxxxxxxxxx>]

Everyone,
   See JPA fix that fixes SDO temporary redirection of 
SDOMethodAttributeAccessor.getGetMethodReturnType() to superclass
https://fisheye2.atlassian.com/changelog/eclipselink/?cs=8085

   Mine, It looks like the function getGetMethodReturnType() on 
MethodAttributeAccessor is overridden by SDO in 
SDOMethodAttributeAccessor.  So when I overloaded the function in order 
to add a better exception for 323403 by checking for a null Method and 
weaving method names in the getMethodName() - I inadvertently switched 
SDO login processing over to JPA where a null Method is not allowed in 
legacy code before my change - resulting in NPE's on every SDO login.
   Evidently SDO handles a null getMethod.

SDO overrides MethodAttributeAccessor
   public Class getGetMethodReturnType() {
       return attributeClass;
   }

JPA temporarily was run in place of the SDOMethodAttributeAccessor
return PrivilegedAccessHelper.getMethodReturnType(getGetMethod());
where getGetMethod is null

   I reverted to using an "Un-overloaded" function with 0 - parameters 
as the (this) parameter was only required for the exception text.
   I could have placed an additional override function in SDO - but 
decided on not modifying the API.
>new post 8085

[junit] Running 
org.eclipse.persistence.testing.sdo.externalizable.SDOResolvableTestSuite
[junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 1.279 sec

>old 8081
   [junit] java.lang.NullPointerException
   [junit]     at 
org.eclipse.persistence.internal.security.PrivilegedAccessHelper.getMethodReturnType(PrivilegedAccessHelper.java:332)
   [junit]     at 
org.eclipse.persistence.internal.descriptors.MethodAttributeAccessor.getGetMethodReturnType(MethodAttributeAccessor.java:135)
   [junit]     at 
org.eclipse.persistence.mappings.foundation.AbstractTransformationMapping.validateBeforeInitialization(AbstractTransformationMapping.java:1310)
   [junit]     at 
org.eclipse.persistence.descriptors.ClassDescriptor.validateBeforeInitialization(ClassDescriptor.java:5282)
   [junit]     at 
org.eclipse.persistence.oxm.XMLDescriptor.preInitialize(XMLDescriptor.java:469)
   [junit]     at 
org.eclipse.persistence.internal.sessions.DatabaseSessionImpl.initializeDescriptors(DatabaseSessionImpl.java:429)
   [junit]     at 
org.eclipse.persistence.internal.sessions.DatabaseSessionImpl.initializeDescriptors(DatabaseSessionImpl.java:406)
   [junit]     at 
org.eclipse.persistence.internal.sessions.DatabaseSessionImpl.postConnectDatasource(DatabaseSessionImpl.java:667)
   [junit]     at 
org.eclipse.persistence.internal.sessions.DatabaseSessionImpl.login(DatabaseSessionImpl.java:628)
   [junit]     at 
org.eclipse.persistence.oxm.XMLContext.<init>(XMLContext.java:213)
   [junit]     at 
org.eclipse.persistence.oxm.XMLContext.<init>(XMLContext.java:179)
   [junit]     at 
org.eclipse.persistence.oxm.XMLContext.<init>(XMLContext.java:169)
   [junit]     at 
org.eclipse.persistence.sdo.helper.delegates.SDOXMLHelperDelegate.getXmlContext(SDOXMLHelperDelegate.java:576)
   [junit]     at 
org.eclipse.persistence.sdo.helper.delegates.SDOXMLHelperDelegate.getXmlConversionManager(SDOXMLHelperDelegate.java:756)
   [junit]     at 
org.eclipse.persistence.sdo.helper.delegates.SDOXMLHelperDelegate.setLoader(SDOXMLHelperDelegate.java:563)
   [junit]     at 
org.eclipse.persistence.sdo.helper.delegates.SDOXMLHelperDelegate.reset(SDOXMLHelperDelegate.java:734)
   [junit]     at 
org.eclipse.persistence.testing.sdo.externalizable.SDOResolvableTestCases.setUp(SDOResolvableTestCase

>postmortem:
- need to run SDO tests after any descriptor changes as well as Core and JPA

   thank you
   The intel 8085 was an 8-bit CMOS version of the 8080
   /michael


eric.gwin@xxxxxxxxxx wrote:
> Build summary for 2.2.0.v20100825-r8081
> -----------------------------------
> Non-critical compilation issues (if any) repoted in
> the format [BUILDLOG_LINE#: NUMBER_OF_ERRORS]:
> -----------------------------------
> TEST-CORE-SRG
>   Tests run:691 Failures:0 Errors:0
> TEST-JPA-SRG
>   Tests run:199 Failures:0 Errors:0
> TEST-MOXY-SRG
>   Tests run:453 Failures:0 Errors:0
> TEST-SDO-SRG
>   Tests run:120 Failures:0 Errors:120
> TEST-DBWS-SRG
>   Tests run:14 Failures:0 Errors:0
> TEST-DBWS-UTILS-SRG
>   Tests run:28 Failures:0 Errors:0
> -----------------------------------
>
> Build log: (/shared/rt/eclipselink/logs/bsb-trunk_cb_100825-1400.log)
> Build logs can be found on the download server at:
>     http://www.eclipse.org/eclipselink/downloads/build-failures.php
> -----------------------------------
>
> SVN Changes since Last Build:
> ------------------------------------------------------------------------
> r8081 | mobrien | 2010-08-25 13:20:29 -0400 (Wed, 25 Aug 2010)
> Changed paths:
>    M /trunk/foundation/eclipselink.core.test/src/org/eclipse/persistence/testing/tests/validation/NoFieldNameForMappingTest.java
>    M /trunk/foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/exceptions/DescriptorException.java
>    M /trunk/foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/exceptions/i18n/DescriptorExceptionResource.java
>    M /trunk/foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/internal/descriptors/MethodAttributeAccessor.java
>    M /trunk/foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/internal/helper/Helper.java
>    M /trunk/foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/internal/localization/i18n/TraceLocalizationResource.java
>    M /trunk/foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/internal/security/PrivilegedAccessHelper.java
>    M /trunk/foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/mappings/CollectionMapping.java
>    M /trunk/foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/mappings/ForeignReferenceMapping.java
>    M /trunk/foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/mappings/foundation/AbstractTransformationMapping.java
>    M /trunk/jpa/org.eclipse.persistence.jpa/src/org/eclipse/persistence/internal/jpa/weaving/ClassWeaver.java
>    M /trunk/jpa/org.eclipse.persistence.jpa/src/org/eclipse/persistence/internal/jpa/weaving/MethodWeaver.java
> ------------------------------------------------------------------------
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
>