Re: [eclipselink-dev] Changes to core.test...failure on junit.jar valida

["Michael O'Brien" <michael.obrien@xxxxxxxxxx>]

Eric,
    eclipselink.core.test trunk build failure on new junit validation after update to 5460 - missing junit.jar variable.

    Just a heads up, I am getting a trunk build failure with the new code in core.test/build.xml from SVN txn# 5460
    My 5465 txn to enable backwards compatibility with legacy machines running 2gb worked fine until I refreshed and picked up 5460 - the 2 transactions are not related.
    Nothing changed with my JUnit setup between refreshes (I am running the jars from my Ant lib directory)
    See
http://fisheye2.atlassian.com/browse/eclipselink/trunk/foundation/eclipselink.core.test/build.xml?r=5460

egwin	5460	206	<target name="compile" depends="init_paths" description="compile EclipseLink core tests">
		207	<fail message="Cannot find junit: '${junit.jar}'." unless="junit.jar.exist"/>

>Build before 5460
Core LRG with override on 12GB machine
  [junit] Tests run: 1333, Failures: 0, Errors: 0, Time elapsed: 697.688 sec

>Build after 5460

BUILD FAILED
C:\view_w342e\build.xml:275: The following error occurred while executing this line:
C:\view_w342e\foundation\eclipselink.core.test\build.xml:207: Cannot find junit: '${junit.jar}'.

Total time: 2 minutes 6 seconds
C:\view_w342e>

>Fix: We are missing a junit.jar definition in build.properties.
There is an existing
junit.lib=../../../extension.lib.external/junit.jar
I added my own <user-dir>/build.properties override "junit.jar" instead of "junit.lib"
junit.jar=../../../extension.lib.external/junit.jar
As well as hardcoding to my own JUnit libs and I am unable to get past this new verification.

thank you
/michael
Eric Gwin wrote:

Hi,

I just checked in an initial pass at reorganizing the core.test build on trunk (2.0.0). The build was successful with several test configurations, and passed the SRG. However, let me know if you encounter any problems.

I will be incrementally checking in each test build as I complete the migration to adopt:
- the current build standards (original reorg was never done on the tests)
- detect  'product' to use for testing:  eclipselink.jar, bundles or 'classes' dirs - in that order.
- improve performance by isolating initialization and conditionals in an init target

The second phase of this reorg will focus on creating generic testing artifacts to streamline the test process and remove redundant building.

Thanks.

-Eric
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev