Re: [eclipselink-dev] [Fwd: [Bug 248999] 17 JPA tests fail while running

[christopher delahunt <christopher.delahunt@xxxxxxxxxx>]

Hello Darani,

Test changes look fine, but for me, more needs to go into the bug 
explanation and why these changes are necessary.  From the exceptions 
thrown from the tests in question, Glassfish seems to be wrapping 
queries in a proxy and then throwing an exception when they get executed 
- regardless of the EntityManager they are associated to being in a 
transaction or not.  The specification seems to state that the context 
needs to be in a transaction when the query executes, not when the query 
is created - otherwise why not throw the exception straight away when an 
update query is created.  To me, this seems like be a bug in the 
glassfish proxy, not in the tests.  Am I missing something?


Best Regards,
Chris



Darani Yallapragada wrote:
> Please do review the patch for Bug#248999 and let me know if any 
> changes are supposed to be  made.
>
> Darani
>
> ------------------------------------------------------------------------
>
> Subject:
> [Bug 248999] 17 JPA tests fail while running against GlassFish
> From:
> bugzilla-daemon@xxxxxxxxxxx
> Date:
> Mon, 29 Sep 2008 14:56:51 -0400 (EDT)
> To:
> Darani.Yallapragada@xxxxxxx
>
> To:
> Darani.Yallapragada@xxxxxxx
>
>
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=248999  
> Product/Component: EclipseLink / JPA
>
>
>
>
> --- Comment #1 from Darani Yallapragada <darani.yallapragada@xxxxxxx>  2008-09-29 14:56:54 -0400 ---
> Created an attachment (id=113788)
>  --> (https://bugs.eclipse.org/bugs/attachment.cgi?id=113788)
> FixForBug 248999
>
> The attachment is the diff of "EntityManagerTestSuite.java" in which the
> queries (deleteQuery) are defined within the transaction in these two methods 
> "testFindDeleteAllPersist()" and 
> "internalTestReadTransactionIsolation(boolean shouldOriginalBeInParentCache,
> boolean shouldUpdateAll, boolean shouldRefresh, boolean shouldFlush)"
>
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
>