[eclipselink-dev] RE: Fix for bug 222698 - Review Required - non-transla

["Michael O'Brien" <michael.obrien@xxxxxxxxxx>]

EclipseLink developers,

    The following change has been committed.

 

    Description:

        TraceLocalization logs that are untranslated now perform a key:value lookup

 

http://bugs.eclipse.org/222698

 

    Code Reviewed by:

        David Minsky - thank you

 

    Core tests:

        All + 1 new - pass

 

    /michael

-----Original Message-----
From: Michael O'Brien [mailto:michael.obrien@xxxxxxxxxx]
Sent: Monday, March 17, 2008 14:48
To: 'Eclipselink-Dev (E-mail)'
Subject: Fix for bug 222698 - Review Required - non-translated FINE* logs are printing their key instead of value message

EclipseLink committers,

    The following patch is available for review.

 

http://bugs.eclipse.org/222698

 

    Description:

        Any call like the following that has its message encoded in TraceLocalization will print out its' untransformed key instead of the value message.

 

            AbstractSessionLog.getLog().log(SessionLog.FINER,"cmp_init_transformer_is_null");

 

        Add code to do a key:value lookup on any untranslated (non-value) log message keys defined in TraceLocalization (FINE, FINER, FINEST are not translated).

        Add to AbstractSessionLog for !shouldTranslate()

        message = TraceLocalization.buildMessage(message,entry.getParameters());

 

Before:

-->[EPS Finer]: 2008.03.17
11:44:00.203--Thread(Thread[main,5,main])--cmp_init_transformer_is_null

After:
-->[EPS Finer]: 2008.03.17
11:44:35.229--Thread(Thread[main,5,main])--JavaSECMPInitializer - transformer
is null.

   

    Please review when you have a chance and send any feedback, thank you

    /michael