Hi Mike,
As my code review was only focused on the XML
Schema for the deployment XML changes below are some initial comments on the
code. They are specifically aimed at the mapping of the
metadata:
- XMLDescriptors are inherently aggregate and do not
need to be specified as such. the xmlDescriptor.descriptorIsAggregate()
calls are not required.
- The ClassExtractor for the wrapper classes should
not be required. Instead you can use the QNameInheritancePolicy which
handles the inheritance indicator using the xsi:type attribute.
-Blaise
----- Original Message -----
Sent: Wednesday, December 12, 2007 10:49
AM
Subject: [eclipselink-dev] Fix for bug
211611 (add deployment xml support forPLSQLStoredProcedureCall)
The patch being checked in for bug 211611 is attached at
the link below. https://bugs.eclipse.org/bugs/show_bug.cgi?id=211611
There
are actually 2 patches - the first for the changes to eclipselink.core, the
second for new tests (ported over from ADE: tltest/tsrc/dbws/nonJDBC,
tltest/tsrc/dbws/plsqlrecord)
The changes have been reviewed by Blaise
and Doug; however, since there are changes to the Project XML schema, I
would like someone from the ORM team to give it a (+1) vote before I commit
the changes.
-- Mike Norman
| Principal Software Designer | 613.288.4638 Oracle Server Technologies |
TopLink Product 45 O'Connor Street, Suite 400 | Ottawa, ON K1P 1A4 | (fax)
613.238.2818
_______________________________________________ eclipselink-dev
mailing
list eclipselink-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
|