I think merge if required policy is probably preferred. But can we still get a gerrit build run automatically when a merge commit is pushed to master? I'm not suggesting this as a way to block the gerrit submission. Instead it is a way to at least have a sanity build of the merge commit along with the other changes it merged with in master. Otherwise there is a slight risk of introducing a build break that goes unnoticed until the nightly build.
Tom
----- Original message -----
From: "Daniel Megert" <daniel_megert@xxxxxxxxxx>
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
To: eclipse-pmc@xxxxxxxxxxx
Cc:
Subject: [EXTERNAL] Re: [eclipse-pmc] Gerrit submit strategies proposal
Date: Fri, Oct 4, 2019 4:36 AM
Looks like the tendency is +1.
The PMC discussion was deferred to next Tuesday, where we will make the final call.
Dani
From: Lars Vogel <lars.vogel@xxxxxxxxxxx>
To: eclipse-pmc@xxxxxxxxxxx
Date: 01.10.2019 13:01
Subject: [EXTERNAL] Re: [eclipse-pmc] Gerrit submit strategies proposal
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
+1 I don't think that the rebased changes are reviewed again and
again, committers just have to wait a long time to get a merge window
and that is demotivating.
Now that our committer and contributor community activity has hugely
increased, we should remove that demotivating approach.
On Tue, Oct 1, 2019 at 12:40 PM Aleksandar Kurtakov <akurtako@xxxxxxxxxx> wrote:
>
> We are seeing an increating contributions and our gerrit verification jobs start to suffer due to our usage of "Fast forward only" strategy. Reality though is that no one rebases his change multiple times and wait for gerrit again just because another commit went in, I've tried and in platform.ui I gave up on 3rd rebase and just pushed it right after rebase. But even this generated one more totally useless gerrit build.
> So my proposal is to change our strategy to "Rebase if Necessary" - I don't see any downside using it and multiple benefits - free a lot of time on our builders, reduce interruptions for contributors and so on.
> Let's discuss today on PMC call
>
> Strategies explained: https://gerrit-review.googlesource.com/Documentation/concept-changes.html#submit-strategies
>
> --
> Alexander Kurtakov
> Red Hat Eclipse Team
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/eclipse-pmc
--
Eclipse Platform project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc
