Re: [eclipse-pmc] Requesting approval for bug 527411

["Daniel Megert" <daniel_megert@xxxxxxxxxx>]

Hi Noopur

The code changes look good to me, but
please upload a Gerrit change for R4_7_maintenance and have it reviewed
by a second person. That person should also confirm that the provided example
works with the fix. Could a test be added?

+1 for RC4 when those things are done.

Dani



From:      
 "Noopur Gupta"
<noopur_gupta@xxxxxxxxxx>
To:      
 eclipse-pmc@xxxxxxxxxxx
Date:      
 29.11.2017 10:07
Subject:    
   [eclipse-pmc]
Requesting approval for bug 527411
Sent by:    
   eclipse-pmc-bounces@xxxxxxxxxxx

---

Hello all, 

I would like to request approval for releasing the fix for bug 527411.
It fixes the handling of dynamic tests and parameterized tests in JUnit
5 when run as plug-in tests. Without the fix, running such plug-in tests
results in no test found message and the tests are not displayed correctly
in the JUnit view. The fix is already present in master since last week.

Regards,
Noopur
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Dpmc&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=kbBPIxG64bnOM-xLva9GKUcAjnplxQyRg1_5jDgvKxE&s=ChMG3d45YLDh9Y0UNtuIcbb3OdBF0H32R7YDxfADfa8&e=