Re: [eclipse-pmc] Requesting approval for SWT bug 527860

["Daniel Megert" <daniel_megert@xxxxxxxxxx>]

I've added Lakshmi to review https://git.eclipse.org/r/#/c/112512/. Assuming her +2 I also approve for RC4.

Dani



From:      
 Aleksandar Kurtakov
<akurtako@xxxxxxxxxx>
To:      
 eclipse-pmc@xxxxxxxxxxx
Date:      
 29.11.2017 09:51
Subject:    
   Re: [eclipse-pmc]
Requesting approval for SWT bug 527860
Sent by:    
   eclipse-pmc-bounces@xxxxxxxxxxx

---

On Wed, Nov 29, 2017 at 10:43 AM, Andrey Loskutov
<loskutov@xxxxxx> wrote:
> Hello all,
>
> I would like to request approval for releasing fix for bug 527860
(https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.eclipse.org_bugs_show-5Fbug.cgi-3Fid-3D527860&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=XddeVuVehr9ItmPlCPNupGMkfBtjju-VbwIJ7Ox45-g&s=e9hE_BkWATGp02qLD0dB_tFrqKk5SyvtxjAK59x9L88&e=).
> This fixes a regression for all Linux GTK3 users (default platform
for Eclipse on Linux), where the click on an toolbar in the inactive view
doesn't activate the view anymore.
> This fix is just flipping one boolean flag which deactivated this
functionality for GTK3 in 4.7 as a side effect of another change.
> The disabled code worked fine before 4.7 and still works fine with
GTK2 builds on 4.7.
>
> The fix is straight forward and is already in master.

+1
If/when we get one more PMC approval I'll set the flag.
>
>
> Kind regards,
> Andrey Loskutov
>
> https://urldefense.proofpoint.com/v2/url?u=http-3A__google.com_-2BAndreyLoskutov&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=XddeVuVehr9ItmPlCPNupGMkfBtjju-VbwIJ7Ox45-g&s=IhU0kQpo7et8itHCEGxrWoxUUdBk0Dgn99uYSMMblDI&e=
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Dpmc&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=XddeVuVehr9ItmPlCPNupGMkfBtjju-VbwIJ7Ox45-g&s=brQZ98QIhZPg1vwpuMcIZvIysYNRjIY_p1xcEbsrmQ8&e=



-- 
Alexander Kurtakov
Red Hat Eclipse Team
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Dpmc&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=XddeVuVehr9ItmPlCPNupGMkfBtjju-VbwIJ7Ox45-g&s=brQZ98QIhZPg1vwpuMcIZvIysYNRjIY_p1xcEbsrmQ8&e=