+1 for the addition from me. It simplifies using MessageDialog, and the risk (of introducing bad/unmaintainable API) looks very low to me.
Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind
River
From:
<eclipse-pmc-bounces@xxxxxxxxxxx> on behalf of Lars Vogel <lars.vogel@xxxxxxxxxxx>
Reply-To: "eclipse-pmc@xxxxxxxxxxx" <eclipse-pmc@xxxxxxxxxxx>
Date: Friday 21 April 2017 at 16:09
To: "eclipse-pmc@xxxxxxxxxxx" <eclipse-pmc@xxxxxxxxxxx>
Subject: Re: [eclipse-pmc] API Request for additional method in MessageDialog
> It looks like I could just replace the call with the 4 lines of code in the body. I.e. as it says in the comment, it looks like a convenience method.
As Dani stated
"convenience" is the key here. I would like to avoid creating several lines of code to replace a one-liner.
"required to continue" was a bit strong.
On Fri, Apr 21, 2017 at 3:56 PM, Mike Wilson <Mike_Wilson@xxxxxxxxxx> wrote:
Apologies for being dense... Can someone explain why this is "required to continue the usage of verbs in Dialogs"? It looks like I could just replace the call with the 4 lines of code in the body. I.e. as it says in the comment,
it looks like a convenience method.
McQ.
"Daniel Megert" ---2017/04/21 09:19:21---I'm
0 on this as is it not really urgent/critical for 4.7. Dani
From: "Daniel Megert" <daniel_megert@xxxxxxxxxx>
To: eclipse-pmc@xxxxxxxxxxx
Date: 2017/04/21 09:19
Subject: Re: [eclipse-pmc] API Request for additional method in MessageDialog
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
I'm 0 on this as is it not really urgent/critical for 4.7.
Dani
From: Lars Vogel <lars.vogel@xxxxxxxxxxx>
To: eclipse-pmc@xxxxxxxxxxx
Date: 21.04.2017 14:44
Subject: [eclipse-pmc] API Request for additional method in MessageDialog
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
Hi,
on behave of David Weiser I would like to ask for permission to add
API to MessageDialog.
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=514245
The change adds the following method to MethodDialog:
public static int open(int kind, Shell parent, String title, String
message, int style,
String... dialogButtonLabels) {
The method itself has 4 lines of code.
See: https://git.eclipse.org/r/#/c/95299/2/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageDialog.java
This method is required to continue the usage of verbs in Dialogs
instead of OK, as several of the existing dialogs use the existing
open method using the SWT.SHEET style and we do not want to change
that.
I believe the risk of this new API is minimal.
Best regards, Lars
--
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email:
lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
--
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email:
lars.vogel@xxxxxxxxxxx, Web:
http://www.vogella.com
|