[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [eclipse-pmc] Request to relax the type bound for the navigatorContent/commonSorter extension
|
+1
One question, would it make sense to capture in the docs somewhere why the legacy type is also still supported (just to avoid accidentally breaking compatibility in a future release, when it looks like the legacy type doesn't make sense anymore).
Right now, the .exsd at least has no trace of ViewerSorter any more so some sort of "internal" doc in that respect might make sense.
Thanks,
Martin
--
Martin Oberhuber, SMTS / Product Owner - Development Tools, Wind River
direct +43.662.457915.85 fax +43.662.457915.6
-----Original Message-----
From: eclipse-pmc-bounces@xxxxxxxxxxx [mailto:eclipse-pmc-bounces@xxxxxxxxxxx] On Behalf Of Aleksandar Kurtakov
Sent: Wednesday, March 22, 2017 3:03 PM
To: eclipse-pmc@xxxxxxxxxxx
Subject: Re: [eclipse-pmc] Request to relax the type bound for the navigatorContent/commonSorter extension
----- Original Message -----
> From: "Andrey Loskutov" <loskutov@xxxxxx>
> To: "pmc" <eclipse-pmc@xxxxxxxxxxx>
> Sent: Wednesday, 22 March, 2017 3:54:30 PM
> Subject: [eclipse-pmc] Request to relax the type bound for the
> navigatorContent/commonSorter extension
>
> Dear PMC,
>
> I would like to get approval to integrate the change
> https://git.eclipse.org/r/93613 for bug 484248.
>
> The change allows clients to contribute sorters to common navigator
> which extend recommended ViewerComparator instead of deprecated
> ViewerSorter type (deprecated via bug 402464).
>
> The change only relaxes the type bound allowed in the
> org.eclipse.ui.navigator "navigatorContent" extension and does not
> change the Java API. Existing code should not be affected by this
> change, because it can't use ViewerComparator anyway.
>
> The main driving reason for this change is to avoid confusion of
> clients trying to cleanup their code and move from deprecated type but
> then facing runtime errors because the ViewerComparator is not
> supported (yet) by the common navigator framework. See for example bug
> 513876 and bug 484248 comment 1.
+1 from me. Looks safe and it's a shame we are still referencing in non-deprecated extension point to deprecated class for so long.
>
> Kind regards,
> Andrey Loskutov
>
> http://google.com/+AndreyLoskutov
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
>
--
Alexander Kurtakov
Red Hat Eclipse team
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/eclipse-pmc
