Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-pmc] Permission to fix bug 492681 for RC1: "Wizard filter should search descriptions"

It helps in discoverability.  In the JEE package, there are about 60 “New” wizards.  It’s frustrating to find out that you missed a wizard because you didn’t use the right keywords!

Brian.

On 3-May-2016, at 9:13 AM, Mike Wilson <Mike_Wilson@xxxxxxxxxx> wrote:

I have no problem with the particulars of the fix, but it doesn't strike me as something we'd typically do in RC1. Is there some burning reason why it needs to go in now versus ".1"?

McQ.

<graycol.gif>Brian de Alwis ---2016/05/02 22:14:12---I’d like to request permission to include the fix for Bug 492681 for RC1: [Wizards] Wizard filter s

From: Brian de Alwis <briandealwis@xxxxxxxxx>
To: eclipse-pmc@xxxxxxxxxxx
Date: 2016/05/02 22:14
Subject: [eclipse-pmc] Permission to fix bug 492681 for RC1: "Wizard filter should search descriptions"
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx





I’d like to request permission to include the fix for Bug 492681 for RC1:

[Wizards] Wizard filter should search descriptions
https://bugs.eclipse.org/bugs/show_bug.cgi?id=492681
Fix:
https://git.eclipse.org/r/#/c/71682/

Our New, Import, and Export wizards support filtering the list of wizards shown based on some user-provided words. These keywords match against the wizard label and associated keywords, but not the wizard description.  I suspect this was an oversight as there are a several wizards where commonly-used terms are included in the wizard description.  For example, the WTP ‘Enterprise Application Project’ wizard creates what is commonly referred to as an EAR project, but EAR is only in the wizard description.

The fix is tiny and the risk is small to negligible.  The fix simply applies the wordMatches() routine to the wizard description field. This wordMatches() is already used for filtering the wizard label and keywords, and guards against a null input.  The implementation to fetch the wizard description retrieves the field from the IExtensionRegistry, in a similar manner to how the wizard label and keywords are retrieved.  The wizard description is shown in the title area of the wizard, so users won’t be mystified as to why a wizard was included.

Thanks!

Brian.
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc


_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-pmc


Back to the top