[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[eclipse-pmc] An issue regarding org.eclipse.compare.win32 plug-in
|
At the beginning of 3.5 we added org.eclipse.compare.win32 plug-in that
provides compare UI for Word documents.
I found two issues with it.
First is, all platform/OS specific behavior is usually provided in
fragments. Here we have a plug-in providing such specific behavior.
I would turn org.eclipse.compare.win32 into a fragment.
Second is, the only package in the plug-in is
org.eclipse.compare.internal.win32. It is of course internal (not API)
package,
however it is marked as visible to other plug-ins (in plugin.xml). This is
an oversight.
These issues should be fixed. Do I need PMC approvals to proceed?.
--
Szymon Brandys
Staff Software Engineer
Eclipse Platform Workspace
szymon.brandys@xxxxxxxxxx
(+48 12) 628 9857
IBM SWG Lab, Cracow, Poland
IBM Polska Sp. z o.o. oddział w Krakowie
ul. Armii Krajowej 18
30 -150 Kraków
NIP: 526-030-07-24
Sąd Rejonowy dla m.st. Warszawy, XIII Wydział Gospodarczy KRS
KRS 0000012941, Kapitał zakładowy: 33 000 000 PLN
