Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[eclipse-pmc] API request: reduction of API in FilteredItemsSelectionDialog


API REQUEST

In FilteredItemsSelectionDialog.

Remove the overloaded method ItemsFilter#matchesRawNamePattern(String) and make
the ContentProvider for the dialog private.

ItemsFilter#matchesRawNamePattern(Object) is the only one called in the
implementation and the overloaded version is superfluous.

The internal ContentProvider should never have been protected as it is only
meant to be accessed by FilteredItemsSelectionDialog.

RISKS
None. No one is currently calling these methods.

Back to the top