Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-dev] SWT repositories moved to Github


On Tue, Mar 29, 2022 at 1:40 AM Alexandr Miloslavskiy <alexandr.miloslavskiy@xxxxxxxxxxx> wrote:
On 2022-03-28 20:37, Aleksandar Kurtakov wrote:
> These Git repositories are now moved to GitHub:
> https://github.com/eclipse-platform/eclipse.platform.swt
> and
> https://github.com/eclipse-platform/eclipse.platform.swt.binaries

I have a few questions regarding the move.

I understand that some of these could be work in progress, but now that
I don't know if yes or no, I better mention everything.

Simple questions:
1) Is it correct that we should now delete `.git/hooks/commit-msg` that
was generating Gerrit IDs before?

Yes, there is no point in keeping it although it would not break anything if someone forgets to do so.
 
2) How do I use my committer powers (if I happen to want to use them) in
the new repo?

Go to a PR (e.g. https://github.com/eclipse-platform/eclipse.platform.swt/pull/3 ) at the bottom of the page there is "Rebase and merge"/"Squash and merge" button (as you choose), click it and PR will be merged. I'm not sure if that was your question though. And please don't hesitate to use your committer powers. We need people doing reviews and merging things as much as we need people submitting patches!
 

Bigger question:
I understand that we now rely on GitHub PRs instead of Gerrits. I would
love to see the usual practice of PRs consisting of branches of properly
chunked commits. I understand that previously patches were rather done
in "single commit" style mostly due to Gerrit limitations. Now that
GitHub PRs show entire pull request as a single thing that shows all
associated commits, there is seemingly no roadblock to start making
chunked commits. What do you think?

Github supports PR on top of PR (aka Gerrit style) if you think you need it (see https://blog.logrocket.com/using-stacked-pull-requests-in-github/ ). I never felt the need for that as usually it takes me more time to get the next commit ready than the review/push of the first one.
 

Things that still seem to need adjustment:
1) Auto-adding GitHub pull requests to 'See also' and comment like 'PR
was created' in Bugzilla
Bugzilla is scheduled for removal so no support would be done for it. See https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Gerrit/Gerrit-and-Bugzilla-deprecation-and-migration-plan . Just create GH issues for new problems. For existing bugzillas manually add see also as it would be easier than duplicating the info in GH.
2) Old repo URLs still mentioned here
    https://www.eclipse.org/swt/git.php

Thanks, I'll fix that.
 


Feature requests
1) It would be nice to continue to auto-detect stuff like "Bug 123456"
as links to Bugzilla. Not sure if that's easily possible on Github.

Just put "#2" in your commit message/header and GH will make it link to the GH issue.
 
_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse-dev

Back to the top