Re: [eclipse-dev] [platform-dev] Eclipse Photon RC2 reminders

["Daniel Megert" <daniel_megert@xxxxxxxxxx>]

> The
doc should be reworked in words that says that in any case, 3 committers
(may include the submitters) needs to approve the change.

No. Only two are
needed besides the person (committer or non-committer). Which person merges
is irrelevant as long as two committers who did not participate in the
fix are reviewed the change and +1 the bug report. If you have a better
wording to express that, let me know and I will update the doc.

Dani



From:
       Mickael
Istria <mistria@xxxxxxxxxx>
To:
       "General
development mailing list of the Eclipse project." <eclipse-dev@xxxxxxxxxxx>
Date:
       22.05.2018
14:17
Subject:
       Re:
[eclipse-dev] [platform-dev] Eclipse Photon RC2 reminders
Sent
by:        eclipse-dev-bounces@xxxxxxxxxxx

---

On Tue, May 22, 2018 at 2:12 PM, Daniel
Megert <daniel_megert@xxxxxxxxxx>
wrote:
For RC2 two committers
(excluding the one who made the fix) are needed to give the +1 and also
do the review. For details see https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_8.php#FixPassAfterRC1.


Ok, but while Alex did explain me in
more details in this case it would involve the contributor + 3 committers,
I don't think this can be infered from the explanation in the initial email,
here or in the link.
The comment here is written in a way
that seems to assume that only a committer can push a patch; and this is
not true at all. Especially in those particular cases, the submitter isn't
a contributor.
The doc should be reworked in words that
says that in any case, 3 committers (may include the submitters) needs
to approve the change.
-- 
Mickael Istria
Eclipse
IDE developer, for Red
Hat Developers
_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev