Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-dev] [jdt-dev] Moving JDT's LTKbundlestoeclipse.platform.text?
Hmm, I look at http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/tree/org.eclipse.ltk.core.refactoring/pom.xml and don't see anything related to Gerrit :). So you would have to tell me exactly what should I look for :)

Alex

On Thu, Nov 9, 2017 at 5:37 PM, Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
I never talk about Gerrit links ;-) Look at it again.

Dani



From:        akurtakov <akurtakov@xxxxxxxxx>
To:        "General development mailing list of the Eclipse project." <eclipse-dev@xxxxxxxxxxx>
Date:        09.11.2017 16:23
Subject:        Re: [eclipse-dev] [jdt-dev] Moving JDT's LTK        bundlestoeclipse.platform.text?
Sent by:        eclipse-dev-bounces@eclipse.org





On Thu, Nov 9, 2017 at 4:29 PM, Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
> Indeed, moved content won't be available any more. But I don't get why this is more an issue than removing any other file in a Git repo. What makes it a possible blocker here?

Because it affects tons of files. It would be good to have a redirect in place.

Dani, are you speaking for open Gerrits or for gerrit links in cgit?
For the former - there aren't that many open gerrits or we are doing really bad job in welcoming people to contribute. Even if there are ( less than 100 gerrits against jdt.ui repo, not sure how many are against ltk bundles) - applying them before or rebasing them would not be that much of effort.
For the later - I am all for preserving history, context and etc. but when this goes to a state where it prevents further improvements and rationalizing of our procedures, codebase, collaboration it becomes more than obvious that we have hit a limit in how much can be preserved in a sane way. Furthermore, personaly I have a special feeling about gerrit links being considered that important now - it always felt like duplication and waste of resources to have BZ and gerrit. BZ is our ultimate tracking tool and bz links will not get broken so gerrit changes will still be accessible through bz links. IMHO such a gerrit redirect would be nice to have but in no way a pre-req for driving some part of the project further.


Dani



From:        Mickael Istria <mistria@xxxxxxxxxx>
To:        "Eclipse JDT general developers list." <jdt-dev@xxxxxxxxxxx>
Cc:        "General development mailing list of the Eclipse project." <eclipse-dev@xxxxxxxxxxx>, jdt-dev-bounces@xxxxxxxxxxx, eclipse-dev-bounces@eclipse.org
Date:        09.11.2017 15:25
Subject:        Re: [eclipse-dev] [jdt-dev] Moving JDT's LTK bundles        toeclipse.platform.text?
Sent by:        eclipse-dev-bounces@eclipse.org





On Thu, Nov 9, 2017 at 3:13 PM, Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
Here is a very simple and obvious example: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/tree/org.eclipse.ltk.core.refactoring/pom.xml

Indeed, moved content won't be available any more. But I don't get why this is more an issue than removing any other file in a Git repo. What makes it a possible blocker here?

A Gerrit change is against a repository. If the changed project is moved, the Gerrit change won't work anymore (unless it gets fixed, as mentioned in my message).

Ok, I'll check Gerrit changes to find those which ones affect the LTK bundles. For other changes, a simple rebase would work._______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=2pV_VAHeoEGebjHyZTYr2aG1IsfqIeNOaPDourCUVR4&s=aYZmU4OZdkvmSvlNSnEMNX1M3JuKtMWmyeeCbMH5rfw&e=



_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev
_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_eclipse-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=ET0bBMuCj8EexSSS2xjj5sNelxeGFryjc6CIViIRpMY&s=embmdmZpddo-fFUh37oNTCcefa61Uuv01z4BxTNCNJM&e=



_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev

Back to the top