Re: [eclemma-dev] Dark theme support in Eclemma?

[Evgeny Mandrikov <mandrikov@xxxxxxxxx>]

P.S. at the very beginning even understanding of what means "Dark theme" for various people took some time - there is for example https://marketplace.eclipse.org/content/darkest-dark-theme, with which BTW EclEmma already IMO has good colors, as well as maybe IDE in general

On Wed, Jun 27, 2018 at 12:50 AM Evgeny Mandrikov <mandrikov@xxxxxxxxx> wrote:

On Tue, Jun 26, 2018 at 2:00 PM Lars Vogel <lars.vogel@xxxxxxxxxxx> wrote:

Thanks Evgeny before you spend further time on this, please let me have a look. My current assumption is that it only takes 10 min to support the dark theme.:-) 

Maybe this is 10 min for the guy who knows which extension point should be used and which IDs/tricks in CSS...

 

Let me try this week.

 

Please review / test https://github.com/eclipse/eclemma/pull/24

Before merging I'll also ask my colleagues to provide feedback as well as reporter of https://bugs.eclipse.org/bugs/show_bug.cgi?id=533264

and will test on macOS and Windows tomorrow.

Regards,

Evgeny