Re: [eclemma-dev] Milestone 3.0.0 M1 for Oxygen M4

[Evgeny Mandrikov <mandrikov@xxxxxxxxx>]

On Tue, Nov 8, 2016 at 6:43 PM Marc Hoffmann <hoffmann@xxxxxxxxxxxxxxxxx> wrote:

I successfully installed EclEmma on Eclipse Neon 4.6.1 with
com.mountainminds.eclemma installed previously.

A kind of expectedly :)

 

I noticed that there are still MountainMinds copyright notices:

1) About dialog (see screenshot attached)
2) "License" page in online help

I assume that "License" page is https://github.com/eclipse/eclemma/blob/master/org.eclipse.eclemma.doc/pages/license.html ? 

Indeed during initial contribution no changes were done regarding "MountainMinds" all over the code.

My understanding (based on what I've read at https://www.eclipse.org/projects/handbook/ and if not mistaken heard from Wayne during "Eclipse Committer Orientation" talk at EclipseCon) was that:

• "Eclipse EclEmma" can't be a copyright holder, because projects at Eclipse are not a legal entities
  
• copyright holder stays unchanged
  

But I'm not a legal guy.

 

Some more issues to clarify:

- What should be the link URL in copyright notices and help (see help
page "Support").

I assume that "Support" page is https://github.com/eclipse/eclemma/blob/master/org.eclipse.eclemma.doc/pages/support.html ?

And "http://www.eclemma.org/" is the link URL?

Don't see why it should be changed since we've transferred domain to Eclipse. And what are the alternatives?

All this reminded me comment https://bugs.eclipse.org/bugs/show_bug.cgi?id=506759#c2 :

> Missing legal files ( http://download.eclipse.org/staging/oxygen/buildInfo/reporeports/reports/layoutCheck.txt )

Supposed to be fixed in master as https://bugs.eclipse.org/bugs/show_bug.cgi?id=507085

For the remaining 3 points I created https://bugs.eclipse.org/bugs/show_bug.cgi?id=507101 :

> http://download.eclipse.org/staging/oxygen/buildInfo/reporeports/reports/copyrights.html

Looking on this report my guess was that expectation is just to append "All rights reserved. This program and the accompanying materials are made available under the terms of the Eclipse Public License v1.0 which accompanies this distribution, and is available at http://www.eclipse.org/legal/epl-v10.html" to the existing "Copyright (c) 2006, 2016 Mountainminds GmbH & Co. KG and Contributors".

But now puzzled after your questions and since this report seems to be somehow inconsistent with "About" dialog - for example EGit has "Copyright (c) 2005, 2009 EGit project committers and others." in dialog, but "Copyright (c) 2005, 2009 Shawn Pearce, Robin Rosenberg, et.al." in report.

> Incorrect provider, should be "Eclipse EclEmma" http://download.eclipse.org/staging/oxygen/buildInfo/reporeports/reports/providerNames.html

Clear enough.

> Unsufficient feature description http://download.eclipse.org/staging/oxygen/buildInfo/reporeports/reports/descriptions.html

I thought I know what this means, but now unsure :)

Mickael, Lars, any advices on points above?

 

- Like with version 2.0.0 we should give a detailed explanation in
"Change Log" what happened to EclEmma

Don't worry - on this point rules of the game not changed after move: I'm pretty sure we'll have clean, descriptive and beautiful changelog prior to review of a first release ;)

 

Many thanks for your enormous effort to make this happen!

It was really a quick ride for M1 to not miss a train, but don't worry - I took a breath after it. That's also why played slowpoke with these questions in this thread - excuse me for that ;)

Now that we are on train ( woohoo - "This project is part of Oxygen." appeared on page https://projects.eclipse.org/projects/technology.eclemma ) and progressing well, IMO we are safe and no doubts - we'll reach target in time.

Regards,

Evgeny