Re: [ecd-pmc] works-with-dependency: git hooks

[Martin Lippert <mlippert@xxxxxxxxx>]

Hey!

I think every project has its own way of writing git commit messages. And the committers on projects have commit rights to the repository because they know what the project-specific guidelines for commit messages are. I don’t see a huge reason to prevent anything here.

In addition to that most projects use gerrit for reviewing commits - and can also serve as a safety net for commit messages (and code changes, of course).

Just my 2 cents,
Martin





> Am 21.06.2018 um 06:45 schrieb Oliver Kopp <kopp.dev@xxxxxxxxx>:
> 
> Hi,
> 
> Since you guys are working on IDEs, how do you deal with preventing
> "dumb" issues. For Java code style, there is checkstyle. But what
> about git commit style?
> 
> We outlined our issue at the SOA PMC list (see below). WDYT?
> 
> Cheers,
> 
> Oliver
> 
> ---------- Forwarded message ----------
> From: Oliver Kopp <kopp.dev@xxxxxxxxx>
> Date: 2018-05-08 14:52 GMT+02:00
> Subject: Re: [soa-pmc] works-with-dependency
> To: SOA PMC mailing list <soa-pmc@xxxxxxxxxxx>
> 
> 
> Hi,
> 
> We want to prevent students to accidently commit to the master branch.
> There is a very good git hook published at
> https://gist.github.com/stefansundin/9059706. We would like to include
> this hook in Winery's code repository. The location is the .git-hooks
> directory. (Current contents:
> https://github.com/eclipse/winery/tree/master/.git-hooks)
> 
> We would like to check in that scripts into the source repository.
> These files will not be distributed during the build, but just used
> for improving the development process.
> 
> Would that be possible?
> 
> Cheers,
> 
> Oliver
> 
> 2018-05-08 14:38 GMT+02:00 Lukas Harzenetter <lharzenetter@xxxxxx>:
>> 
>> Hi there,
>> 
>> I want to get your approval for a works-with-dependency for which I created a CQ here: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=16192
>> 
>> Could you please approve this request so I can attach it to the CQ?
>> 
>> Cheers,
>> 
>> Lukas
> _______________________________________________
> ecd-pmc mailing list
> ecd-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/ecd-pmc