Gunnar,
Can you confirm if this is the approach we should take?
We plan to create an EBR in order to create a bundle from mongo driver jar. But the naming will not be "org.eclipse.orbit.mongodb" but will be "com.mongodb"
(most likely "com.mongodb.ebr"?) since we are not changing mongodb driver source.
Let me know if I am mistaken.
thanks,
Derek
From: Derek Lai
Sent: Wednesday, June 22, 2016 8:46 AM
To: Vidyadhara Reddy Vanga; Gunnar Wagenknecht
Cc: Jamie Wang; Orbit Developer discussion; Discussion channel for EBR developers, not for discussion of individual bundles manifests
Subject: RE: EBR for MongoDB (RE: Updating org.eclipse.orbit.mongodb with the latest mongo java driver (3.2.6))
Gunnar,
Thanks for your reply.
Vidyadhar has confirmed that there is no change needed in the mongodb driver jar:
With Gunnar’s update, I have checked the existing JAR “org.eclipse.orbit.mongodb_2.10.1.v20130422-1135.jar ” modified text file.
It has following content:
“The class org/bson/io/UTF8Encoding.java has been replaced with a clean-room implementation that just delegates to the JDR method.The original file was
copied from PostgreSQL which has provenance issues.
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4889#c10””
Until Mongo DB 2.x version the org/bson/io/UTF8Encoding.java was present but from Mongo DB 3.x version this file was removed. So don’t need to do changes
to Mongo DB 3.x driver source.
I just want to confirm our next steps.
It seems to me that we will need to create an EBR in order to create a bundle from mongo driver jar. But the naming will not be "org.eclipse.orbit.mongodb"
but will be "com.mongodb" (most likely "com.mongodb.ebr"?) since we are not changing mongodb driver source.
Is that the right understanding? Let me know if I am mistaken.
thanks,
Derek
From: Vidyadhara Reddy Vanga
Sent: Wednesday, June 22, 2016 2:52 AM
To: Gunnar Wagenknecht
Cc: Derek Lai; Jamie Wang; Orbit Developer discussion; Discussion channel for EBR developers, not for discussion of individual bundles manifests
Subject: RE: EBR for MongoDB (RE: Updating org.eclipse.orbit.mongodb with the latest mongo java driver (3.2.6))
Hi Gunnar,
Thanks for the detailed information . We will follow these guidelines to create new EBR.
Thanks & Regards,
Vidyadhar.
From: Gunnar Wagenknecht [mailto:gunnar@xxxxxxxxxxxxxxx]
Sent: Wednesday, June 22, 2016 3:08 PM
To: Vidyadhara Reddy Vanga
Cc: Derek Lai; Jamie Wang; Orbit Developer discussion; Discussion channel for EBR developers, not for discussion of individual bundles manifests
Subject: Re: EBR for MongoDB (RE: Updating org.eclipse.orbit.mongodb with the latest mongo java driver (3.2.6))
(cc'ed orbit-dev and ebr-dev to make them aware of the discussion)
Hi,
There are few things mixed up here.
1. no CQ is required for publishing receipts in EBR
2. one CQ is required for the new version of the library
3. another CQ is required for adding a new version of a library to Orbit
The name "org.eclipse.orbit.mongodb" was used because the MongoDB drive code had been modified for IP reasons in order to be distributed by Eclipse projects. Details are noted on the original CQ as well as in the CVS and in the jar itself.
There should be a MODIFIED.txt file.
As long as that IP issue is still in place, any new version of the MongoDB driver must be patched again and again. The CQ should unveil any such IP issues.
If the modification is not longer required, the BSN should change from "org.eclipse.orbit.mongodb" to "com.mongodb" as per the Orbit naming conventions.
For EBR, the namespace "org.eclipse" must not be used. Instead, you should use "com.mongodb.ebr". As a side note, EBR also does not address any IP issues. There is no IP review of any library. Just the recipes need to be IP clean (contributed
properly). It must be clear that a bundle created from a recipe cannot be distributed by an Eclipse project. A full IP review is required (see rule #2 above).
So, if you want to update the library in Orbit, these are the steps that must be performed:
1. Create a CQ for the new version of the library.
2. Wait till it is approved (you can continue in case of parallel IP process)
3. Create a CQ for adding it to Orbit
4. Prepare the library for Orbit (using EBR and the advices given above)
5. Submit Gerrit review with the recipe to the Orbit Git repo.
For test build I ran following command
mvn -U clean package -DdirtyWorkingTree=warning and I got below error message
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:0.23.0:build-qualifier (default-build-qualifier) on project org.eclipse.mongod
b.ebr: Working tree is dirty.
[ERROR] git status recipes/unsorted/org.eclipse.mongodb.ebr_3.2.2:
[ERROR] recipes/unsorted/org.eclipse.mongodb.ebr_3.2.2/src/main/resources/about.html
[ERROR] recipes/unsorted/org.eclipse.mongodb.ebr_3.2.2/osgi.bnd
[ERROR] recipes/unsorted/org.eclipse.mongodb.ebr_3.2.2/src/main/resources/about_files/THE_APACHE_SOFTWARE_LICENSE__VERSION_2.0.txt
[ERROR] recipes/unsorted/org.eclipse.mongodb.ebr_3.2.2/.project
[ERROR] recipes/unsorted/org.eclipse.mongodb.ebr_3.2.2/pom.xml
[ERROR] recipes/unsorted/org.eclipse.mongodb.ebr_3.2.2/src/main/resources/OSGI-INF/l10n/bundle.properties
[ERROR] You are trying to use tycho-buildtimestamp-jgit on a directory that has uncommitted changes (see details above).
[ERROR] Either commit all changes/add files to .gitignore, or enable fallback to
default timestamp provider by configuring
[ERROR] jgit.dirtyWorkingTree=warning for tycho-packaging-plugin
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] For more information about the errors and possible solutions, please read the following articles:
To proceed further I added recipes\unsorted to .gitignore file and build was successful.
Could you please let me know for information that you want to check.
