Re: [eavp-dev] The github repo

["Kozhokanova, Anara" <kozhokanovaa@xxxxxxxx>]

Jay,

Alex already told me to discuss the details with him before doing anything. So now, the discussion will be communicated to you and Robert additionally.

To your questions for the records of EAVP's evolvement:

1) I haven't dived into the whole code yet, but it's my understanding now that the change in the EAVP's code will primarily be in o.e.eavp.viz.servie bundle.

2) The original implementation of EAVP didn't allow consuming its services outside of Eclipse's workbench. You answered this one already yourself in a previous message: "unfortunately a common problem when using a project in a new way (in this case without the Eclipse workbench around)".

3) My strategy for now is to focus and identify the dependencies and to see how they can be resolved efficiently. Is there any EAVP records of other strategies that I could refer to?

4) "I don't want you to start down a path where you make changes to the code that we cannot accept back into EAVP later." I don't want to waste my time neither.

Anara

---

From: eavp-dev-bounces@xxxxxxxxxxx <eavp-dev-bounces@xxxxxxxxxxx> on behalf of Jay Jay Billings <jayjaybillings@xxxxxxxxx>
Sent: Thursday, April 20, 2017 4:06 PM
To: eavp developer discussions
Subject: Re: [eavp-dev] The github repo

 

Anara,

And by that I mean - what are you changing? Why are you changing those pieces? What strategy are you taking for changing this? Etc.

Jay

On Thu, Apr 20, 2017 at 4:03 PM, Jay Jay Billings <jayjaybillings@xxxxxxxxx> wrote:

Anara,

You should come up with a plan and discuss it with Robert and I before you just start coding. I don't want you to start down a path where you make changes to the code that we cannot accept back into EAVP later. I think if you just write out your plan in response to this email that we would have a good place to start.

Jay

On Thu, Apr 20, 2017 at 9:09 AM, Kozhokanova, Anara <kozhokanovaa@xxxxxxxx> wrote:

It seems it's possible to refactor the part of code in EAVP so that it's not tied to Eclipse's workbench. I am going to continue working on this.

Anara

---

From: eavp-dev-bounces@xxxxxxxxxxx <eavp-dev-bounces@xxxxxxxxxxx> on behalf of Jay Jay Billings <jayjaybillings@xxxxxxxxx>
Sent: Thursday, April 20, 2017 8:57 AM
To: eavp developer discussions

Subject: Re: [eavp-dev] The github repo

 

Anara,

That's very interesting, and unfortunately a common problem when using a project in a new way (in this case without the Eclipse workbench around). Good catch. 

Jay

On Thu, Apr 20, 2017 at 8:40 AM, Kozhokanova, Anara <kozhokanovaa@xxxxxxxx> wrote:

The reason why the factory's constructor wasn't even executed is because the DS in the o.e.eavp.viz.service required at least 1 reference to eclipse's workbench which was not in our implementations. When the cardinality was set to 0-1, the constructor became reachable.

The github ticket #147 was updated accordingly.

Anara

---

From: eavp-dev-bounces@xxxxxxxxxxx <eavp-dev-bounces@xxxxxxxxxxx> on behalf of Kozhokanova, Anara <kozhokanovaa@xxxxxxxx>
Sent: Thursday, April 20, 2017 8:19 AM
To: eavp developer discussions
Subject: [UNTRUSTED] Re: [eavp-dev] The github repo

 

Jay, the ticket was created yesterday already and I updated it with your latest comments.

Anara

---

From: eavp-dev-bounces@xxxxxxxxxxx <eavp-dev-bounces@xxxxxxxxxxx> on behalf of Jay Jay Billings <jayjaybillings@xxxxxxxxx>
Sent: Wednesday, April 19, 2017 7:13 PM
To: eavp developer discussions
Subject: Re: [eavp-dev] The github repo

 

Anara, please file a bug for this at the GitHub repo. You may note in your bug that I encountered the same problem using EAVP from the p2 repository (whereas you encountered it from source code).

Robert, will you jump on this bug and help Anara figure out the problem please?

I might try to take another look at it tonight too. When I run the OSGi console in ICE (2.2.1RC1) and look at the service, I see the following:

org.eclipse.eavp.viz.service_0.1.1.201701231839 [208]

  Id=208, Status=ACTIVE      Data Root=/home/jay/ICEResearch/ice-2.2.1RC1-20170214/configuration/org.eclipse.osgi/208/data

  "Registered Services"

    {org.eclipse.eavp.viz.service.IVizServiceFactory}={service.id=310, service.bundleid=208, service.scope=bundle, component.name=org.eclipse.eavp.viz.service.factory, component.id=76}

However, when I run Anara's Vaadin bundle using the EAVP bundles that are in the exact same running instance of ICE (i.e. - through the native target and p2 repo, not from source), I get:

org.eclipse.eavp.viz.service_0.1.1.201701231839 [79]

  Id=79, Status=ACTIVE      Data Root=/home/jay/Documents/anaraWorkspace/.metadata/.plugins/org.eclipse.pde.core/stable-test2/org.eclipse.osgi/79/data

  "No registered services."

I'll check in on your progress when I get a break from the meeting tomorrow. Please respond on the list as you make progress so that we can log it.

Jay

On Wed, Apr 19, 2017 at 4:14 PM, Jay Jay Billings <jayjaybillings@xxxxxxxxx> wrote:

Thanks Anara. Will you also enter a ticket at https://github.com/eclipse/eavp please?

Jay

On Apr 19, 2017 3:32 PM, "Kozhokanova, Anara" <kozhokanovaa@xxxxxxxx> wrote:

There's is an issue with OSGi and the service provider that the latter is not being executed.

Here's the link to the repo:

https://github.com/anarak/eavp/tree/anara/vaadin

Use 'stable-test2' launch configuration.

Anara

_______________________________________________
eavp-dev mailing list
eavp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eavp-dev

--

Jay Jay Billings

Oak Ridge National Laboratory

Twitter Handle: @jayjaybillings

_______________________________________________
eavp-dev mailing list
eavp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eavp-dev

--

Jay Jay Billings

Oak Ridge National Laboratory

Twitter Handle: @jayjaybillings

_______________________________________________
eavp-dev mailing list
eavp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eavp-dev

--

Jay Jay Billings

Oak Ridge National Laboratory

Twitter Handle: @jayjaybillings

--

Jay Jay Billings

Oak Ridge National Laboratory

Twitter Handle: @jayjaybillings