[eavp-dev] Fw: [eclipse/eavp] EAVP only handles one delimiter? (#137)

["Smith, Robert W." <smithrw@xxxxxxxx>]

---

From: Billings, Jay Jay
Sent: Friday, March 03, 2017 1:53 PM
To: Smith, Robert W.
Subject: Fw: [eclipse/eavp] EAVP only handles one delimiter? (#137)

 

Robert,

Please see my email below. Also, will you forward it to the dev list please, for the record? Apparently my ORNL address isn't subscribed and I can't get into GMail from here.

Jay

Jay Jay Billings

Team Lead, Scientific Software Development
Oak Ridge National Laboratory
Twitter Handle: @jayjaybillings

---

From: Billings, Jay Jay
Sent: Friday, March 03, 2017 1:52 PM
To: eavp-dev@xxxxxxxxxxx
Subject: Fw: [eclipse/eavp] EAVP only handles one delimiter? (#137)

 

Nice Robert! I'll try this out soon. However, I think I noticed a small bug when I read the code: Will your code assume that a "." is a delimiter if it encounters it, in which case I can't have floating point numbers in my file? The new scanning code seems to only pick up characters in the numericalChars array, which does not contain ".".

There's an alternative way to implement this that you might consider. I don't know that it is necessarily better than what you have since we don't have anyone using this yet. The other technique is simple: Instead of allowing a certain type of numerical character, you could allow only a certain type of delimiter. Then, you can do something like:

for (String candidateDelimiter : delimiters) {

      if (line.contains(candidateDelimiter)) {

         delimiter = candidateDelimiter;

      }

}

Obviously there is a bug if a line contains two of the elements of delimiter, but then it should fail since these files contain numerical data. The advantage that I can see of this implementation over yours is that we can control the types of supported delimiters. Again, I'm not sure if that is necessary at this point, but this is just something to keep in mind.

Good work and thanks for getting this fixed,

Jay

Jay Jay Billings

Team Lead, Scientific Software Development
Oak Ridge National Laboratory
Twitter Handle: @jayjaybillings

---

From: SmithRWORNL <notifications@xxxxxxxxxx>
Sent: Friday, March 03, 2017 10:43 AM
To: eclipse/eavp
Cc: Billings, Jay Jay; Assign
Subject: Re: [eclipse/eavp] EAVP only handles one delimiter? (#137)

 

Fixed by commit 42d4707

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.