Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[dsdp-tm-dev] Re: What is defect 44544 ?

The 5 number defects refer to our internal IBM bug tracking system. In many
cases I'd like to keep some reference to these. However, if the method is
deprecated I see no need to keep them.
_______________________
David Dykstal
david_dykstal@xxxxxxxxxx


                                                                           
             "Oberhuber,                                                   
             Martin"                                                       
             <Martin.Oberhuber                                          To 
             @windriver.com>           David Dykstal/Rochester/IBM@IBMUS   
                                                                        cc 
             02/11/2008 07:23          "Target Management developer        
             AM                        discussions"                        
                                       <dsdp-tm-dev@xxxxxxxxxxx>           
                                                                   Subject 
                                       What is defect 44544 ?              
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




Hi Dave,

In order to refactor SystemRegistry implementation from UI to Core,
I'd like to get rid of deprecated ISystemViewInputProvider#getShell()

Doing so, I came across this line #364 in SystemView.java:


inputProvider.setShell(getShell()); // DY: Defect 44544, shell was not
being set for Test dialogs, when they
// tried to connect there was not shell for the password prompt
// and an error message (expand failed) occurred.


I'd like to get rid of these lines since I'm very sure we don't need
them in OpenRSE; because, when deprecated
ISystemViewInputProvider#getShell() no longer exists,
setting the shell is useless.

Can you check why these lines were there originally,,
and whether it's OK applying attached patch?

Thanks,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm

 (See attached file: getRid_getShell.diff.txt)

Attachment: getRid_getShell.diff.txt
Description: Binary data


Back to the top