[dsdp-tm-dev] FW: Changed SystemViewSubSystemAdapter for [174299]

["Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>]

Hi Dave,

reading your comment sounds as if your change would make
it impossible to have multiple instances of e.g. 
FileServiceSubSystem with different services in the 
same connection. 

For instance, FTP and SSH-Files in the same connection. 

Is this correct? If yes, then I'm not sure if this is 
such a good idea. I'd prefer being able to have multiple
different ServiceSubsystems rather than being able to
switch the service of the single one.

Thanks,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
-----Original Message-----
From: dsdp-tm-cvs-commit-bounces@xxxxxxxxxxx
[mailto:dsdp-tm-cvs-commit-bounces@xxxxxxxxxxx] On Behalf Of Eclipse CVS
Genie
Sent: Monday, March 26, 2007 7:33 PM
To: dsdp-tm-cvs-commit@xxxxxxxxxxx
Subject: [dsdp-tm-cvs-commit]
dmcknightorg.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rs
e/internal/ui/viewSystemViewSubSystemAdapter.java

Update of
/cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclip
se/rse/internal/ui/view
In directory
node5:/tmp/cvs-serv27459/UI/org/eclipse/rse/internal/ui/view

Modified Files:
	SystemViewSubSystemAdapter.java 
Log Message:
[174299] serivce subsystems need to be identified by the service type,
not the service name.  In order to retrieve the correct subsystem model
object via hashmap, the absolute name of the subsystem must be the same
regardless of service implemnetation.

Index: SystemViewSubSystemAdapter.java
===================================================================
RCS file:
/cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclip
se/rse/internal/ui/view/SystemViewSubSystemAdapter.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -d -r1.7 -r1.8
*** SystemViewSubSystemAdapter.java	16 Mar 2007 16:12:37 -0000
1.7
--- SystemViewSubSystemAdapter.java	26 Mar 2007 17:32:53 -0000
1.8
***************
*** 26,29 ****
--- 26,30 ----
  import org.eclipse.rse.core.model.ISystemRegistry;
  import org.eclipse.rse.core.subsystems.IConnectorService;
+ import org.eclipse.rse.core.subsystems.IServiceSubSystem;
  import org.eclipse.rse.core.subsystems.ISubSystem;
  import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
***************
*** 149,153 ****
  	{
  		ISubSystem ss = (ISubSystem)element;
! 		return ss.getSystemProfileName() + "." +
ss.getHostAliasName() + "." + ss.getName(); //$NON-NLS-1$ //$NON-NLS-2$
  	}		
  	/**
--- 150,164 ----
  	{
  		ISubSystem ss = (ISubSystem)element;
! 		
! 		// DKM - using type instead of name
! 		if (ss instanceof IServiceSubSystem)
! 		{
! 			return ss.getSystemProfileName() + "." +
ss.getHostAliasName() + "." + ((IServiceSubSystem)ss).getServiceType();
//$NON-NLS-1$ //$NON-NLS-2$
! 		}
! 		else
! 		{
! 			return ss.getSystemProfileName() + "." +
ss.getHostAliasName() + "." + ss.getName(); //$NON-NLS-1$ //$NON-NLS-2$
! 		}
! 		
  	}		
  	/**

_______________________________________________
dsdp-tm-cvs-commit mailing list
dsdp-tm-cvs-commit@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-tm-cvs-commit