Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[Dltk-dev] DLTK API: to break or not to break

Hi folks,

Recent commit to Zend breaks API resulting in _javascript_ component do not compile. So I'd like to ask all the committers to be more thoughtful on API changes.

When you can do anything without breaking API, please do not break API:

Last commit introduce getMethods() method to ISourceModule class. Obviously ISourceModule is an interface which used heavily among DLTK components and Core. DLTK feeling good without this method, so it's very likely just committed functionality will live well without this breaking API change. getMethods() is used from single place of new functionality and can be easily inlined instead. [Andrei just removed getMethods() and inlined that functionality]

I'm not contrary to changing API, but uncontrolled API grow result in a number of problems (like _javascript_ won't build today).

So please if you *really need* to break API, please post that changes on the list to understand impact on components and get everyone prepared to follow that changes.

Kind Regards,
Andrey


Back to the top