It was necessary and announced 4 months ago. It is not Platform team's job to respond to previously announced removal notices and clean up other projects in simrel. Standard practice is that early projects (platform is +0) to disable downstream projects that have not adapted to such advanced notice. This is the purpose of M1 anyway, to resolve these things >2 months before release.
Remeber that in the past a release cycle started by disabling everything. I assume. You are not advocating for that.
As for the 8 hour delay, I assume that complaint about an open source project was a joke?
You haven't explained why Modisco or Parsley were disabled or why
there was no discussion prior to such a widespread unnecessary
disabling.
Yes the disabling has eventually been reverted, but unfortunately
there was an 8 hour delay between the Gerrit that reverted and the
actual merge. IMHO until the merge occurs, there was no reversion.
Regards
Ed Willink
On 08/01/2022 15:33, Jonah Graham
wrote:
Hi Eike,
Actually CDO does depend on Mylyn, and therefore (until
2021-12) on CVS:
(Note that despite the name
org.eclipse.mylyn.github.feature.feature.group is contributed
by EGit to simrel)
The difference is the granularity of the dependencies. For
SimRel dependencies are normally handled at the contribution
level. At the feature/bundle level there may indeed be no
dependencies from CDO -> Mylyn/CVS, but with many
contributions being interdependent on each other, and Mylyn
historically cutting across so many projects, something that
disabled Mylyn causes many things to be easily disabled.
Of course this problem is hindered by Mylyn being
under-resourced at the moment.
Let me clarify. While
contributing Eclipse Project M1 to SimRel 2022-03 M1,
SimRel Aggregator Validation found many dependency
issues "directly" or "indirectly" related to the
removal of CVS in Eclipse Project. Mylyn was the first
offender. After disabling Mylyn, all the other
downstream projects also needed to be disabled because
they were "directly" or "indirectly" affected by the
removal of CVS and/or Mylyn.
Thanks to Jonah's
analysis, most/all of the downstream projects were
affected by Mylyn. Once Mylyn fixed their CVS
dependency, Jonah was able to enable most/all the
other downstream projects.
Sorry for the
inconvenience and the alarm caused by the change!
Regards,
Kit Lo
Eclipse Babel Project Lead
IBM Eclipse SDK (IES) Technical Lead and Release
Manager
"Lorenzo Bettini"
---01/08/2022 05:56:28 AM---Same for EMF Parsley: how
did you find the CVS dependency? Il Sab 8 Gen 2022,
07:16 Ed Willink <ed.w
Ditto for Modisco. My
OOMPH generated Modisco installation is totally free
of even transitive dependencies on CVS so there must
be a fault in your dependency analysis.
Surely such a dramatic
disabling should have been investigated on the
Gerrit / a prvate branch and then discussed? Why was
it merged to master? Why has it not yet been
reverted?
Regards
Ed Willink
On 08/01/2022 05:25, Eike
Stepper wrote:
@Jonah Thanks for
re-enabling CDO!
@Kit How did you establish that CDO depends
(possibly transitively) on CVS? The bundle manifests
of CDO do not contain anything to that extent, and
in my target platform for CDO there are no CVS
bundles.
I have reenabled all the
projects as the failures were due to transitive
dependencies on Mylyn. For Mylyn I have disabled
the CVS related/dependent features only. AFAICT
(validation passes, waiting for full build) this
should be the full solution so none of the other
projects need to do anything this time.
It looks like we have
quite a few dependencies to resolve here :-) CDT
doesn't directly depend on CVS, perhaps there is
a transient dependency that does though.
Does anyone know which
of these directly depend on CVS? I am trying to
figure it out now and hope to make a new
contribution soon if possible with a smaller set
of disabled projects by removing
individual features.
PS Thank you for
making such a large change in M1 - it gives all
the downstream consumers more time to
actually understand the implication of the
earlier announced changes.
As announced in
https://www.eclipse.org/lists/cross-project-issues-dev/msg18643.html Eclipse Platform
project has stopped building CVS. While
contributing to SimRel 2022-03 M1 we found
some projects are dependent on CVS causing
SimRel build to fail. To make SimRel work we
ended up disabling multiple projects. Please
re-enable them once the support for CVS has
been disabled. Here is the list of projects
that were disabled: