Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems

Toolitem

Lars Vogel <lars.vogel@xxxxxxxxxxx> schrieb am Fr., 27. Sep. 2019, 16:36:
Ed, try latest from today in which we converted the button to a tool it's.

Ed Merks <ed.merks@xxxxxxxxx> schrieb am Mi., 25. Sep. 2019, 16:41:

My latest comes from the most recent IBuild, I20190924-1800.   That's definitely the most recent.

It seems pretty clear that this commit replaced the TextField with a Button that brings up a dialog:

  https://git.eclipse.org/c/platform/eclipse.platform.ui.git/diff/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/quickaccess/SearchField.java?id=faf20d3317002d1d79af174ff7673f64ff7569d6

It's part of part of this Bugzilla:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=500618

So it's coming from the platform.ui.

It looks to be a work in progress with a recent suggestion to just use a toolbar button...

On 25.09.2019 16:22, Daniel Megert wrote:
Hi Ed

I'm always on the latest ;-). But I can't see that button in the Eclipse SDK. Is this coming from some other project?

Dani



From:        Ed Merks <ed.merks@xxxxxxxxx>
To:        cross-project-issues-dev@xxxxxxxxxxx
Date:        25.09.2019 16:05
Subject:        [EXTERNAL] Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems
Sent by:        cross-project-issues-dev-bounces@xxxxxxxxxxx




Dani,
Sorry, it's new to a recent 4.14 IBuild:

On 25.09.2019 15:44, Daniel Megert wrote:
> And what about this new-to-2019-09 button?

Where is that?


Dani




From:        
Ed Merks <ed.merks@xxxxxxxxx>
To:        
cross-project-issues-dev@xxxxxxxxxxx
Date:        
25.09.2019 15:33
Subject:        
[EXTERNAL] Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems
Sent by:        
cross-project-issues-dev-bounces@xxxxxxxxxxx




And menus. Might this look "prettier" with more consistent use of images?

And what about this new-to-2019-09 button?

It's a bit ugly in my ignorant opinion.

On 25.09.2019 15:24, Becker, Matthias wrote:

Hi Dani,

 

and what about view and editors?

 

Regards,

Matthias

 

From: <cross-project-issues-dev-bounces@xxxxxxxxxxx>on behalf of Daniel Megert <daniel_megert@xxxxxxxxxx>
Reply to:
Cross project issues
<cross-project-issues-dev@xxxxxxxxxxx>
Date:
Wednesday, 25. September 2019 at 15:21
To:
Cross project issues
<cross-project-issues-dev@xxxxxxxxxxx>
Subject:
Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems

 

Buttons in dialogs should use text and that's what you see in almost all our dialogs. It's also what Microsoft does in its dialogs (can't speak for Mac or Linux).

-1 for using emojis.

Dani




From:        
"Becker, Matthias" <ma.becker@xxxxxxx>
To:        
Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>
Date:        
25.09.2019 11:47
Subject:        
[EXTERNAL] [cross-project-issues-dev] Text and / or Icons on Buttons / Toolbar        Items
Sent by:        
cross-project-issues-dev-bounces@xxxxxxxxxxx


 

Dear Eclipse experts,

 

today I had a discussion with co-workers and I also want your feedback on that topic.

It’s about Text and/or Icons on (Standard) Buttons:

 

Today we see a lot of dialogs in Eclipse where we have buttons that only have text but no icons.

On example is Platforms “Available Update Sites” preference page.

 

There we have Add, Remove, Edit, … on the right hand side of the table.

Btw: Should the “Edit” button not be “Edit…”?

 

Also JDT’s “Change Method Signature” refactoring dialog has a similar pattern:

 

In contrast to that let’s have a look at the “Rebase Interactive” view from EGIT:

 

Here we also have buttons. But they all have icons and in addition they have text below the icons. I find the UI design of the interactive rebase view really good. The “first time users” (that maybe

don’t know the meaning of some icons) can directly read the text (and don’t need to hover with the mouse) and will (maybe) learn the icons.
In addition there’s a context menu and we have key binding for the various actions.

 

Let’s have a look at an additional location of icons and text. The perspective switcher:

Here we also have Icons and text (but not on the right hand side) by default but the “power user” can switch the text off.

 

What’s the reason for not having icons on the other locations? The Add, Remove, Up, Down and Edit buttons could also get icons (that already either already exist in Eclipse or are known by “everybody” from every day’s life).

 

Regards,

Matthias

 

 

 

 [attachment "image001.png" deleted by Daniel Megert/Zurich/IBM] [attachment "image002.png" deleted by Daniel Megert/Zurich/IBM] [attachment "image003.png" deleted by Daniel Megert/Zurich/IBM] [attachment "image004.png" deleted by Daniel Megert/Zurich/IBM] _______________________________________________
cross-project-issues-dev mailing list

cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev




_______________________________________________
cross-project-issues-dev mailing list

cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev[attachment "pikfeogbbcnbmjan.png" deleted by Daniel Megert/Zurich/IBM] [attachment "ngpdbkndgdjcdaal.png" deleted by Daniel Megert/Zurich/IBM] _______________________________________________
cross-project-issues-dev mailing list

cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev



_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev[attachment "dddbdilgjajnplcc.png" deleted by Daniel Megert/Zurich/IBM] _______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev



_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev

Back to the top