Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] Build problems with recent platform4.11-I-builds 
Hi
Your build.properties lines were consistent with the Java 6 support for @NonNull in o.e.jdt.annotation 1.0.0 which was a compile-time only declaration annotation.
o.e.jdt.annotation 2.0.0 exploits Java 7 type annotations which persist at run-time. You must therefore require o.e.jdt.annotation just like any other bundle. 

Regards

Ed Willink


On 15/02/2019 21:29, Bernd Hufmann wrote:

Hi,

Thanks, Carsten for the suggestions.

I was able to fix the build by changing the way that the Trace Compass plug-ins reference the o.e.jdt.annotation bundle. We used the following lines in the build.properties:
additional.bundles = org.eclipse.jdt.annotation
jars.extra.classpath = platform:/plugin/org.eclipse.jdt.annotation

Now, I removed the 2 lines added the following as Required-Bundle to the MANIFEST.MF file:
org.eclipse.jdt.annotation;bundle-version="[2.0.0,3.0.0)";resolution:=optional

According to the JDT documentation [1] this is the recommended way.

How did I find this? Well, I noticed that all our core plug-ins (non-ui) didn't have the problem and all our UI plug-ins did. Then I checked all the commits in the platform UI repositories, and I found a commit [2] that added the o.e.jdt.annotation as optional bundle reference. So, I tried the same and it works [3]. Why and whether this change in the platform lead to the build failure, I don't really know. Right now, I'm glad that I'm able to create a successful build which we will need for the 2019-03 M3 contribution.

Best Regards
Bernd

[1] https://help.eclipse.org/2018-12/index.jsp?topic=/org.eclipse.jdt.doc.user/tasks/task-using_null_annotations.htm&cp=1_3_9_0_2&anchor=buildpath_setup
[2] https://git.eclipse.org/r/#/c/133991/
[3] https://git.eclipse.org/r/#/c/137047/


-----Original Message-----
From: cross-project-issues-dev-bounces@xxxxxxxxxxx <cross-project-issues-dev-bounces@xxxxxxxxxxx> On Behalf Of Carsten Reckord
Sent: February-15-19 5:09 AM
To: Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>
Subject: Re: [cross-project-issues-dev] Build problems with recent platform4.11-I-builds

Hi Bernd,


I still try to understand why the change in my target definition to
use a different platform updates site causes this particular failure
while using the same java, tycho and Trace Compass version. I don't see the connection.

You could use mvn -X -Dtycho.debug.resolver=true to compare the effective target platforms used by Tycho for the broken projects.

However, looking at your configuration, you are using the jdt.annotations bundle from the running platform, i.e. Tycho, not your target platform, so I'm not sure if that would help...

Best of luck,
Carsten
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev



---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Back to the top