| [cosmos-dev] Issue with data managers running outside eclipse |
| Mark D Weitzel/Raleigh/IBM@IBMUS
01/17/2008 02:21 PM |
|
|
| From: | "Todd, John A" <John.Todd@xxxxxx> | |
| To: | "Hubert H Leung" <hkyleung@xxxxxxxxxx>, "Muldoon, William H" <William.Muldoon@xxxxxx> | |
| Cc: | "Hawkins, Joel" <Joel.Hawkins@xxxxxxxxxxxxx>, "Devine, John T" <John.Devine@xxxxxx>, "Stratton, Paul" <Paul.Stratton@xxxxxx>, Mark D Weitzel/Raleigh/IBM@IBMUS |
| "Muldoon, William
H" <William.Muldoon@xxxxxx>
01/17/2008 11:01 AM |
|
| "Hawkins, Joel" <Joel.Hawkins@xxxxxxxxxxxxx>
01/17/2008 10:44 AM |
|
Hubert,
From what I understood (wrongly – it appears), you were getting the stack trace during registration whenever you ran. It wasn’t clear to me that this only occurs running outside of OSGi. When I ran, I got a different exception, which I attributed to some sort of race condition. When I flipped the implementation over to use declarative services on both ends, everything registered fine.
Looking at your code, I agree that it should work – I’m wondering if it’s a problem with the equinox declarative services implementation, where the service registration event is going out before the service is actually initialized. In the binding code, I use the activate call to initialize muse, and I’m wondering if DS is sending the registration event prior to the activate returning.
IIRC, ProSyst had donated a production-strength implementation of DS to equinox – is that the one we’re running with?
Can you point me to your current build?
Thanks,
Joel
-----Original Message-----
From: Hubert H Leung [mailto:hkyleung@xxxxxxxxxx]
Sent: Thursday, January 17, 2008 10:25 AM
To: Todd, John A
Cc: Hawkins, Joel; Devine, John T; Stratton, Paul; Muldoon, William
H
Subject: RE: Build issue
Joel, can you briefly summary your findings on what caused the problem?
The proposed change is pretty big. It changes the programming model
and affects existing data managers.
The reason why I didn't use declarative service is because I didn't want
every developer who need to create a data manager or MDR to create a component
XML, and let the framework handle the osgi service related details. I
will look for a simpler solution.
_________________________
Hubert Leung
IBM Toronto Lab
hkyleung@xxxxxxxxxx
905-413-3382
| "Todd, John A" <John.Todd@xxxxxx>
01/17/2008 09:59 AM |
|
I had a look at the patch, though some of it is greek to me.
The problem is that its not as easy as applying the patch to workspace
and trying it out, because my workspace already works just fine,
Its what the build generates that is a pickle, so there is some environmental
factor involved.
- John
From: Hawkins, Joel [mailto:Joel.Hawkins@xxxxxxxxxxxxx]
Sent: Thursday, January 17, 2008 7:43 AM
To: Todd, John A; Hubert H Leung
Cc: Devine, John T; Muldoon, William H; Stratton, Paul
Subject: RE: Build issue
Patch below – it’s a multi-project patch – give it a shot and let me
know what you think. I left the AbstractDataManagerActivator intact –
it’s just not used anymore.
Cheers,
Joel
### Eclipse Workspace Patch 1.0
#P org.eclipse.cosmos.dc.logging.datamgr
Index: build.properties
===================================================================
RCS file: /cvsroot/technology/org.eclipse.cosmos/data-collection/org.eclipse.cosmos.dc.logging.datamgr/build.properties,v
retrieving revision 1.2
diff -u -r1.2 build.properties
--- build.properties 7 Jan 2008 19:23:21
-0000 1.2
+++ build.properties 17 Jan 2008 12:40:40 -0000
@@ -1,7 +1,6 @@
source.. = src/
output.. = bin/
-bin.includes = META-INF/,\
- .,\
+bin.includes = .,\
bin/,\
logs/,\
src/
Index: src/org/eclipse/cosmos/dc/logging/datamgr/Activator.java
===================================================================
RCS file: /cvsroot/technology/org.eclipse.cosmos/data-collection/org.eclipse.cosmos.dc.logging.datamgr/src/org/eclipse/cosmos/dc/logging/datamgr/Activator.java,v
retrieving revision 1.1
diff -u -r1.1 Activator.java
--- src/org/eclipse/cosmos/dc/logging/datamgr/Activator.java
19 Dec 2007 21:02:52 -0000 1.1
+++ src/org/eclipse/cosmos/dc/logging/datamgr/Activator.java
17 Jan 2008 12:40:40 -0000
@@ -12,13 +12,19 @@
import org.eclipse.cosmos.dc.dataManager.api.IDataManager;
import org.eclipse.cosmos.dc.dataManager.impl.AbstractDataManagerActivator;
+import org.osgi.framework.BundleActivator;
+import org.osgi.framework.BundleContext;
-public class Activator extends AbstractDataManagerActivator {
+public class Activator implements BundleActivator /* AbstractDataManagerActivator
*/ {
- @Override
- protected IDataManager getDataManagerInstance()
{
-
return new LoggingDataManager();
+ public void start(BundleContext arg0)
throws Exception {
+
// TODO Auto-generated method stub
+
}
+ public void stop(BundleContext arg0)
throws Exception {
+
// TODO Auto-generated method stub
+
+ }
-}
+}
\ No newline at end of file
Index: META-INF/MANIFEST.MF
===================================================================
RCS file: /cvsroot/technology/org.eclipse.cosmos/data-collection/org.eclipse.cosmos.dc.logging.datamgr/META-INF/MANIFEST.MF,v
retrieving revision 1.2
diff -u -r1.2 MANIFEST.MF
--- META-INF/MANIFEST.MF 15 Jan 2008 20:16:21 -0000
1.2
+++ META-INF/MANIFEST.MF 17 Jan 2008 12:40:40 -0000
@@ -5,8 +5,12 @@
Bundle-Version: 1.0.0
Bundle-Activator: org.eclipse.cosmos.dc.logging.datamgr.Activator
Bundle-Vendor: Eclipse.org
-Import-Package: org.osgi.framework;version="1.3.0"
+Import-Package: org.osgi.framework;version="1.3.0",
+ org.osgi.service.component;version="1.0.0"
Require-Bundle: org.eclipse.cosmos.dc.dataManager,
org.apache.muse.complete,
org.eclipse.cosmos.dc.logging.datamgr.common,
org.eclipse.cosmos.common
+Service-Component: META-INF/DataManager.xml
+Bundle-ClassPath: .
+
Index: src/org/eclipse/cosmos/dc/logging/datamgr/LoggingComponent.java
===================================================================
RCS file: src/org/eclipse/cosmos/dc/logging/datamgr/LoggingComponent.java
diff -N src/org/eclipse/cosmos/dc/logging/datamgr/LoggingComponent.java
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ src/org/eclipse/cosmos/dc/logging/datamgr/LoggingComponent.java
1 Jan 1970 00:00:00 -0000
@@ -0,0 +1,14 @@
+package org.eclipse.cosmos.dc.logging.datamgr;
+
+import org.eclipse.cosmos.dc.dataManager.api.IDataManager;
+import org.eclipse.cosmos.dc.dataManager.impl.AbstractDataManagerComponentFactory;
+import org.osgi.service.component.ComponentContext;
+
+public class LoggingComponent extends AbstractDataManagerComponentFactory
{
+
+ @Override
+ protected IDataManager getDataManagerInstance()
{
+
return new LoggingDataManager();
+ }
+
+}
Index: META-INF/DataManager.xml
===================================================================
RCS file: META-INF/DataManager.xml
diff -N META-INF/DataManager.xml
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ META-INF/DataManager.xml 1
Jan 1970 00:00:00 -0000
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+
+<component name="DataManager" immediate="true"
>
+ <implementation class="org.eclipse.cosmos.dc.logging.datamgr.LoggingComponent"
/>
+ <reference name="WSDM"
interface="org.eclipse.cosmos.dc.mgmt.binding.Binding" cardinality="1..1"
policy="static" />
+ <reference name="ContributionManager"
interface="org.eclipse.cosmos.dc.mgmt.common.ContributionManager"
cardinality="1..1" policy="static" />
+</component>
#P org.eclipse.cosmos.dc.dataManager
Index: src/org/eclipse/cosmos/dc/dataManager/impl/AbstractDataManagerActivator.java
===================================================================
RCS file: /cvsroot/technology/org.eclipse.cosmos/data-collection/org.eclipse.cosmos.dc.dataManager/src/org/eclipse/cosmos/dc/dataManager/impl/AbstractDataManagerActivator.java,v
retrieving revision 1.5
diff -u -r1.5 AbstractDataManagerActivator.java
--- src/org/eclipse/cosmos/dc/dataManager/impl/AbstractDataManagerActivator.java
15 Jan 2008 20:26:46 -0000
1.5
+++ src/org/eclipse/cosmos/dc/dataManager/impl/AbstractDataManagerActivator.java
17 Jan 2008 12:40:42 -0000
@@ -87,6 +87,10 @@
case ServiceEvent.REGISTERED:
ServiceReference ref = context.getServiceReference("org.eclipse.cosmos.dc.mgmt.common.ContributionManager");
if (ref != null) {
+
try {
+
Thread.currentThread().sleep(5000);
+
} catch (InterruptedException e1) {
+
}
ContributionManager manager = (ContributionManager)context.getService(ref);
manager.manage(dataMgrImpl);
Index: src/org/eclipse/cosmos/dc/dataManager/impl/AbstractDataManagerComponentFactory.java
===================================================================
RCS file: src/org/eclipse/cosmos/dc/dataManager/impl/AbstractDataManagerComponentFactory.java
diff -N src/org/eclipse/cosmos/dc/dataManager/impl/AbstractDataManagerComponentFactory.java
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ src/org/eclipse/cosmos/dc/dataManager/impl/AbstractDataManagerComponentFactory.java
1 Jan 1970 00:00:00 -0000
@@ -0,0 +1,88 @@
+/*******************************************************************************
+ * Copyright (c) 2007, 2008 IBM Corporation
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ * IBM Corporation - initial API and implementation
+ *******************************************************************************/
+package org.eclipse.cosmos.dc.dataManager.impl;
+
+import java.io.File;
+import java.net.URL;
+import java.util.Properties;
+
+import org.apache.muse.util.xml.XmlUtils;
+import org.apache.muse.ws.addressing.EndpointReference;
+import org.eclipse.cosmos.dc.dataManager.api.IDataManager;
+import org.eclipse.cosmos.dc.mgmt.common.ContributionManager;
+import org.osgi.framework.BundleActivator;
+import org.osgi.framework.BundleContext;
+import org.osgi.framework.ServiceEvent;
+import org.osgi.framework.ServiceListener;
+import org.osgi.framework.ServiceReference;
+import org.osgi.service.component.ComponentContext;
+import org.w3c.dom.Document;
+import org.w3c.dom.Element;
+
+
+/**
+ *
+ * This is the super class of the activator of all bundles that contains
the data manager implementation.
+ *
+ */
+public abstract class AbstractDataManagerComponentFactory {
+
+ protected BundleContext context;
+ private IDataManager dataMgrImpl;
+
+ /*
+ * (non-Javadoc)
+ * @see org.osgi.framework.BundleActivator#start(org.osgi.framework.BundleContext)
+ */
+ public void activate(ComponentContext
context) throws Exception {
+
+
dataMgrImpl = getDataManagerInstance();
+
+
URL resource = context.getBundleContext().getBundle().getResource("/META-INF/config.properties");
+
Properties dmConfig = new Properties();
+
dmConfig.load(resource.openStream());
+
dataMgrImpl.setConfigProperties(dmConfig);
+
+
String domainEprFile = (String) dmConfig.get(IDataManager.CONFIG_MGMT_DOMAIN_EPR_FILE);
+ if (domainEprFile == null) {
+ // TODO: Log entry
+ System.out.println("Warning: Data
manager registration cannot be completed because EPR of management domain
is not set.");
+ } else {
+
URL domainEprURL = context.getBundleContext().getBundle().getResource(domainEprFile);
+
Document domainEprDoc =
XmlUtils.createDocument(domainEprURL.openStream());
+
Element eprElement = domainEprDoc.getDocumentElement();
+
EndpointReference domainEpr
= new EndpointReference(eprElement);
+
dataMgrImpl.setManagementDomainEPR(domainEpr);
+ }
+
+
this.context = context.getBundleContext();
+
+
ContributionManager manager = (ContributionManager)context.locateService("ContributionManager");
+
manager.manage(dataMgrImpl);
+
+
try {
+
// Try to register data
manager with broker at start up
+
// Log error if unsuccessful.
+
dataMgrImpl.register();
+
} catch (Exception e) {
+
// TODO: log
+
System.out.println("Tried
to register data manager with broker at startup, but registration failed.");
+
}
+ }
+
+ /**
+ * A factory method for returning an
instance of the data manager implementation.
+ * This instance object should be annotated
as a ManagedResource.
+ * @return
+ */
+ protected abstract IDataManager getDataManagerInstance();
+
+}
#P org.eclipse.cosmos.dc.stat.datamgr
Index: build.properties
===================================================================
RCS file: /cvsroot/technology/org.eclipse.cosmos/data-collection/org.eclipse.cosmos.dc.stat.datamgr/build.properties,v
retrieving revision 1.1
diff -u -r1.1 build.properties
--- build.properties 10 Jan 2008 19:07:06
-0000 1.1
+++ build.properties 17 Jan 2008 12:40:43 -0000
@@ -1,4 +1,5 @@
source.. = src/
output.. = bin/
-bin.includes = META-INF/,\
- .
+bin.includes = .,\
+ META-INF/,\
+ bin/
Index: src/org/eclipse/cosmos/dc/stat/datamgr/Activator.java
===================================================================
RCS file: /cvsroot/technology/org.eclipse.cosmos/data-collection/org.eclipse.cosmos.dc.stat.datamgr/src/org/eclipse/cosmos/dc/stat/datamgr/Activator.java,v
retrieving revision 1.1
diff -u -r1.1 Activator.java
--- src/org/eclipse/cosmos/dc/stat/datamgr/Activator.java 10 Jan
2008 19:07:04 -0000 1.1
+++ src/org/eclipse/cosmos/dc/stat/datamgr/Activator.java
17 Jan 2008 12:40:43 -0000
@@ -12,12 +12,19 @@
import org.eclipse.cosmos.dc.dataManager.api.IDataManager;
import org.eclipse.cosmos.dc.dataManager.impl.AbstractDataManagerActivator;
+import org.osgi.framework.BundleActivator;
+import org.osgi.framework.BundleContext;
-public class Activator extends AbstractDataManagerActivator {
+public class Activator implements BundleActivator /* AbstractDataManagerActivator
*/ {
- @Override
- protected IDataManager getDataManagerInstance()
{
-
return new StatisticalDataManager();
+ public void start(BundleContext arg0)
throws Exception {
+
// TODO Auto-generated method stub
+
System.out.println("OK");
+ }
+
+ public void stop(BundleContext arg0)
throws Exception {
+
// TODO Auto-generated method stub
+
}
Index: META-INF/MANIFEST.MF
===================================================================
RCS file: /cvsroot/technology/org.eclipse.cosmos/data-collection/org.eclipse.cosmos.dc.stat.datamgr/META-INF/MANIFEST.MF,v
retrieving revision 1.3
diff -u -r1.3 MANIFEST.MF
--- META-INF/MANIFEST.MF 15 Jan 2008 20:19:08 -0000
1.3
+++ META-INF/MANIFEST.MF 17 Jan 2008 12:40:43 -0000
@@ -5,9 +5,13 @@
Bundle-Version: 1.0.0
Bundle-Activator: org.eclipse.cosmos.dc.stat.datamgr.Activator
Bundle-Vendor: Eclipse.org
-Import-Package: org.osgi.framework;version="1.3.0"
+Import-Package: org.osgi.framework;version="1.3.0",
+ org.osgi.service.component;version="1.0.0"
Require-Bundle: org.eclipse.cosmos.dc.dataManager,
org.apache.muse.complete,
org.eclipse.cosmos.common,
org.eclipse.cosmos.dc.stat.datamgr.common,
org.apache.derby
+Bundle-ClassPath: .
+Service-Component: META-INF/StatDataManager.xml
+Bundle-RequiredExecutionEnvironment: J2SE-1.5
Index: META-INF/StatDataManager.xml
===================================================================
RCS file: META-INF/StatDataManager.xml
diff -N META-INF/StatDataManager.xml
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ META-INF/StatDataManager.xml 1 Jan 1970 00:00:00
-0000
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+
+<component name="org.eclipse.cosmos.dc.stat.datamgr.StatComponent"
immediate="true" >
+ <implementation class="org.eclipse.cosmos.dc.stat.datamgr.StatComponent"
/>
+ <reference name="WSDM"
interface="org.eclipse.cosmos.dc.mgmt.binding.Binding" cardinality="1..1"
policy="static" />
+ <reference name="ContributionManager"
interface="org.eclipse.cosmos.dc.mgmt.common.ContributionManager"
cardinality="1..1" policy="static" />
+</component>
Index: src/org/eclipse/cosmos/dc/stat/datamgr/StatComponent.java
===================================================================
RCS file: src/org/eclipse/cosmos/dc/stat/datamgr/StatComponent.java
diff -N src/org/eclipse/cosmos/dc/stat/datamgr/StatComponent.java
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ src/org/eclipse/cosmos/dc/stat/datamgr/StatComponent.java 1 Jan
1970 00:00:00 -0000
@@ -0,0 +1,15 @@
+package org.eclipse.cosmos.dc.stat.datamgr;
+
+import org.eclipse.cosmos.dc.dataManager.api.IDataManager;
+import org.eclipse.cosmos.dc.dataManager.impl.AbstractDataManagerComponentFactory;
+import org.osgi.service.component.ComponentContext;
+
+public class StatComponent extends AbstractDataManagerComponentFactory
{
+
+
+ @Override
+ protected IDataManager getDataManagerInstance(){
+
return new StatisticalDataManager();
+ }
+
+}
The contents of this e-mail are intended for the named addressee only.
It contains information that may be confidential. Unless you are the named
addressee or an authorized designee, you may not copy or use it, or disclose
it to anyone else. If you received it in error please notify us immediately
and then destroy it.
From: Todd, John A [mailto:John.Todd@xxxxxx]
Sent: Wednesday, January 16, 2008 4:50 PM
To: Hubert H Leung; Hawkins, Joel
Cc: Devine, John T; Muldoon, William H; Stratton, Paul
Subject: Build issue
We tracked why the CBE and Statistical datamanagers don’t get registered
to some kind of annotation issue.
Where it gets stuck is in ManagedProxyInvocationHandler.processAnnotations()
trying to get the methods of the datamanager class
Method methods[] = resourceClass.getMethods();
It does not return from this call
Here’s how it got there.
org.eclipse.cosmos.dc.mgmt.common.util.ManagedProxyInvocationHandler.processAnnotations(ManagedProxyInvocationHandler.java:347)
at org.eclipse.cosmos.dc.mgmt.common.util.ManagedProxyInvocationHandler.<init>(ManagedProxyInvocationHandler.java:443)
at org.eclipse.cosmos.dc.mgmt.common.util.ManagementProxyFactory.getManagedProxy(ManagementProxyFactory.java:125)
at org.eclipse.cosmos.dc.mgmt.osgi.ContributionManagerImpl.manage(ContributionManagerImpl.java:65)
at org.eclipse.cosmos.dc.dataManager.impl.AbstractDataManagerActivator.serviceChanged(AbstractDataManagerActivator.java:111)
at org.eclipse.osgi.framework.internal.core.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:94)
at org.eclipse.osgi.framework.internal.core.BundleContextImpl.dispatchEvent(BundleContextImpl.java:1224)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:195)
at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:141)
at org.eclipse.osgi.framework.internal.core.Framework.publishServiceEventPrivileged(Framework.java:1603)
at org.eclipse.osgi.framework.internal.core.Framework.publishServiceEvent(Framework.java:1578)
at org.eclipse.osgi.framework.internal.core.ServiceRegistrationImpl.<init>(ServiceRegistrationImpl.java:103)
at org.eclipse.osgi.framework.internal.core.BundleContextImpl.createServiceRegistration(BundleContextImpl.java:657)
at org.eclipse.osgi.framework.internal.core.BundleContextImpl.registerService(BundleContextImpl.java:609)
at org.eclipse.equinox.ds.instance.RegisterComponentService.registerService(RegisterComponentService.java:102)
at org.eclipse.equinox.ds.instance.InstanceProcess.registerComponentConfigurations(InstanceProcess.java:153)
at org.eclipse.equinox.ds.resolver.Resolver.dispatchWork(Resolver.java:701)
at org.eclipse.equinox.ds.workqueue.WorkQueue$Queued.dispatch(WorkQueue.java:57)
at org.eclipse.equinox.ds.workqueue.WorkQueue.run(WorkQueue.java:108)
I tried to figure out what’s different about these datamanagers from the
ones that get registered but did not turn up any substantive leads.
I have no idea why it can’t get the methods of the class, or why it does
not return (instead of throwing an exception)
We noticed that if we call getDeclaredMethods() instead, it comes back
but then hangs on a getAnnotation() call on the first one it finds.
I need help figuring this out.
- John