Re: [che-dev] Screenshots on PRs

[Roman Nikitenko <rnikiten@xxxxxxxxxx>]

For me it's valuable:

- at a PR review step. 
It helps to figure out what's done within a PR, what's the difference. Especially, if I'm not very close to a PR area.

- at working on another issue close to the PR changes.
Sometimes it's not clear in codebase why some chages was done, what's behavior was provided and so on.
For such cases I have to open the corresponding PR to clarify some things. It's very helpful if a PR contains a detailed subsсription, it's just luck if a PR contains described use cases, screenshots and gifs. For my PRs I'm trying to provide animated gifs and How to test section as well.

So, in my opinion, it's really cool proposal!

On Thu, Jun 18, 2020 at 4:00 PM Gorkem Ercan <gorkem.ercan@xxxxxxxxx> wrote:

Can we make it a PR practice and perhaps add it to the template to add screenshot or an animated gif of

any UI changes to the PRs?

--

Gorkem

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/che-dev