Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] ci-build-check now required

Hello, 
Thanks for the questions Thomas.

- What does ci-build-check actually execute?
it executes maven build to make sure project compiles 
- Who can start the ci-build-check? How can I tell it has started executing?
this build check started automatically for every new PR submitted by CHE committer, if PR was submitted by person who is not CHE committer procedure will remain the same, Codeowner would run this check along with PR review.
- What do I do if it fails?
This is not e2e tests so in most cases if it fails it means that your changes don't compile so it should be fixed. 
- What are the criteria that make ci-test necessary on a PR?
There is no changes to ci-test we are talking about only ci-build, I would let @Viktor Kuznietsov to comment on ci-test acceptance criteria 
- Why are we doing this?
to make sure project can be built before changes merged to master, unfortunately, very often we had situations where PR reviewed, approved and merged but it does not compile.


On Wed, Nov 21, 2018 at 2:59 PM <tmader@xxxxxxxxxx> wrote:
Hi Roman,

I think the community at large might have some questions about this change, namely:

- What does ci-build-check actually execute?
- Who can start the ci-build-check? How can I tell it has started executing?
- What do I do if it fails?
- What are the criteria that make ci-test necessary on a PR?
- Why are we doing this?

I know all these things might be obvious to you, but not to people outside of the Red Hat teams.

/Thomas

On Wed, 2018-11-21 at 11:18 +0200, Roman Iuvshyn wrote:
hello, 
please be informed that now ci-build-check is required for every PR against eclipse/che repository this check will be started automatically and can be restarted by ci-build trigger phrase in the PR comment.

ci-test is still required to run for most PRs


_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx

To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev


--

ROMAN IUVSHYN

Red Hat 

riuvshyn@xxxxxxxxxx   


Back to the top