Here are variants, that we can use (one or several):
1. Declare change in formatter for source code of Che.
2. Reformat Che codebase.
3. Embed formatter into Eclipse Che editor as default.
4. Add tool into the mvn build that would allow a dev to reformat code on demand. We have similar tool for fixing license headers and sorting pom.xml files.
Note that it won’t be aplied by default on build to not change sources unwillingly.
5. Add tool into the build that fails build in case code is not correctly formatted.
6. As in #5 but don’t enable by default in build and enable it in PRs CI.
7. Add tool into the build that automatically reformats code on each build.
Personally I would apply #1, 2, 3, 4 for sure. I don’t like #7 option. And would try #6 and 7 to see how stable and fast they are.
Alexander Garagatyi | Software Engineer | agaragatyi@codenvy.com |
Looks good, i think we can discuss for a bit the rules itself (supposedly they are good enough) and apply with minimal effort, afaik che formatter uses eclipse, am i right.
Thoughts?
--
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxxTo change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev