Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] Outbound HTTP requests in Che server-side

Hi Yevhenii,

I've inspected your commit and indeed it makes a good start by relying on injection instead of static method. Still, it does not allow intervening the request lifecycle which is the main point of my message. I guess we can solve this by having an alternative implementation of HttpJsonRequestFactory.

Is this planned to replace the scattered code the copies HttpJsonHelper? (e.g. RemoteRunnerProcess.doRequest)

thank you
Tareq Sharafy

 

From: che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx] On Behalf Of Yevhenii Voevodin
Sent: Wednesday 09 December 2015 14:53
To: che developer discussions <che-dev@xxxxxxxxxxx>
Subject: Re: [che-dev] Outbound HTTP requests in Che server-side

 

Hi Tareq.

 

Yes HttpJsonHelper is not convinient to use and test, and because of this we added new builder-like interface-based analogue HttpJsonRequest. The only problem here is that it is in 4.0 branch, but there is no problem to port it into the master.

 

We have some thoughts about JAX-RS Client API, and also wanted to integrate it, but for now we are okay with HttpJsonRequest, and we postponed JAX-RS Client API integration for the next time.  

 

Back to the top