Hello Sergii,
I have refactored the PRs to match your demands, please review:
Git server URI prefix taken to parameter:
https://github.com/codenvy/che/pull/8
https://github.com/codenvy/che-core/pull/143
https://github.com/codenvy/che-plugins/pull/166
Bugfix in native git implementation:
https://github.com/codenvy/che-plugins/pull/165
Thanks,
Alexander
From: che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx]
On Behalf Of Bolshakov, Alexander
Sent: Sunday 05 July 2015 08:20
To: che developer discussions
Subject: Re: [che-dev] Fixes for git plugin
Understood, I will refactor the PRs to make the value of URI prefix configurable. This PR
https://github.com/codenvy/che-plugins/pull/159 is a bugfix not related to URI prefix.
From:
che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx]
On Behalf Of Sergii Kabashniuk
Sent: Thursday 02 July 2015 16:24
To: che developer discussions
Subject: Re: [che-dev] Fixes for git plugin
On Thu, Jul 2, 2015 at 4:14 PM, Bolshakov, Alexander <alexander.bolshakov@xxxxxxx> wrote:
What is the reason that “git” prefix cannot be changed?
1. We already shared a lot of links to git server where path started with "git". It's not easy to rollback
2. Why "git-server"? May be someone likes other name more. Shall we be more flexible? Maybe we should allow this path to be configurable?
From:
che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx]
On Behalf Of Sergii Kabashniuk
Sent: Thursday 02 July 2015 14:32
To: che developer discussions
Subject: Re: [che-dev] Fixes for git plugin
>Why is this a problem to change the prefix?
Yes. this is a problem.
As an option it can be configurable.
On Thu, Jul 2, 2015 at 2:27 PM, Bolshakov, Alexander <alexander.bolshakov@xxxxxxx> wrote:
Currently URI prefix is hardcoded “git”. The PRs are compliant with running git-server was separate
WAR. Git server URL is generated by Che so it would include right prefix. Why is this a problem to change the prefix?
From:
che-dev-bounces@xxxxxxxxxxx [mailto:che-dev-bounces@xxxxxxxxxxx]
On Behalf Of Sergii Kabashniuk
Sent: Thursday 02 July 2015 13:54
To: che developer discussions
Subject: Re: [che-dev] Fixes for git plugin
Hello
-1
"git-server" should not be hurdcoded. We need a way to run git-server as separate war without renaming it.
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev
|