[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [cf-dev] ServerMessageDeliverer Issue #318
|
> I will continue the discussion in issue #318 directly.
Great, thank you!
Mit freundlichen Grüßen / Best regards
Achim Kraus
(INST/ECS4)
Bosch Software Innovations GmbH | Stuttgarter Straße 130 | 71332 Waiblingen | GERMANY | www.bosch-si.com
Sitz: Berlin, Registergericht: Amtsgericht Charlottenburg; HRB 148411 B
Aufsichtsratsvorsitzender: Dr.-Ing. Thorsten Lücke; Geschäftsführung: Dr. Stefan Ferber, Michael Hahn
-----Original Message-----
From: cf-dev-bounces@xxxxxxxxxxx <cf-dev-bounces@xxxxxxxxxxx> On Behalf Of Pellerin, Clement
Sent: Montag, 7. Mai 2018 17:31
To: Californium (Cf) developer discussions <cf-dev@xxxxxxxxxxx>
Subject: Re: [cf-dev] ServerMessageDeliverer Issue #318
I did not get any feedback in the cf-dev mailing list, so I thought I was ignored/overruled.
I will continue the discussion in issue #318 directly.
-----Original Message-----
From: cf-dev-bounces@xxxxxxxxxxx [mailto:cf-dev-bounces@xxxxxxxxxxx] On Behalf Of Kraus Achim (INST/ECS4)
Sent: Monday, May 7, 2018 11:20 AM
To: Californium (Cf) developer discussions
Subject: Re: [cf-dev] ServerMessageDeliverer Issue #318
Hi Clement,
I reopened issue #318 some week ago and added some comments with a question back to you.
If you still interested in this issue, it would be great, if you can answer the questions in the comment.
Especially the "wildcard" is implemented in another way, so it would be interesting for us, if you can use the already provided implementation pattern or if you can provide us some more details about your use-case.
Mit freundlichen Grüßen / Best regards
Achim Kraus
(INST/ECS4)
Bosch Software Innovations GmbH | Stuttgarter Straße 130 | 71332 Waiblingen | GERMANY | www.bosch-si.com
Sitz: Berlin, Registergericht: Amtsgericht Charlottenburg; HRB 148411 B
Aufsichtsratsvorsitzender: Dr.-Ing. Thorsten Lücke; Geschäftsführung: Dr. Stefan Ferber, Michael Hahn
-----Original Message-----
From: cf-dev-bounces@xxxxxxxxxxx <cf-dev-bounces@xxxxxxxxxxx> On Behalf Of Pellerin, Clement
Sent: Dienstag, 27. März 2018 20:37
To: cf-dev@xxxxxxxxxxx
Subject: [cf-dev] ServerMessageDeliverer Issue #318
I would like to make a case to reopen issue #318 because I think we need to remove the final keyword on ServerMessageDeliverer.findResource()
This is the best place to implement wild cards in URI searches like the javadoc suggests:
* Searches in the resource tree for the specified path. A parent resource
* may accept requests to subresources, e.g., to allow addresses with
* wildcards like <code>coap://example.com:5683/devices/*</code>
Unfortunately, the final keyword on findResource() makes this impossible without reimplementing all of deliverRequest(). I don't see how the new preDeliverRequest() helps since we still have to reimplement all of deliverRequest(), so might as well reimplement deliverRequest() directly.
I would argue it is more dangerous to force people to reimplement deliverRequest() and hide any future changes you might make, compared to allowing findResource() overrides. By trying to hide the internals of ServerMessageDeliverer, you are exposing them a lot more.
The only thing missing after removing the final keywords is to add a getRoot() accessor because it is needed to implement our own findResource().
I'm asking for findResource(), but I would prefer if none of the ServerMessageDeliverer methods were final.
_______________________________________________
cf-dev mailing list
cf-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/cf-dev
_______________________________________________
cf-dev mailing list
cf-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cf-dev
_______________________________________________
cf-dev mailing list
cf-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cf-dev
