Re: [cdt-dev] multicore visualizer plugin

[Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>]

On Tue, Aug 21, 2012 at 12:01 PM, Cortell John-RAT042 <RAT042@xxxxxxxxxxxxx> wrote:

Marc, that's a good idea. I've seen it done both ways. Having "internal" in the name makes it obvious that a package is internal, but as you pointed out, causes a headache when the code becomes public.

Unfortunately, I'm already way behind on the build-config work I'm trying to do (sidetracked by test matters), so I'll leave it to you or someone else to do the package rename. As it stands, we get an API tooling error because a Messages class was added to the plugin a while back but the version was not bumped (to 1.1). BTW, I'm talking about the dsf-gdb visualizer plugin

A rule of thumb is that Messages classes should always have package visibility. 

John

-sergey 

---

From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] on behalf of Marc Khouzam [marc.khouzam@xxxxxxxxxxxx]
Sent: Tuesday, August 21, 2012 1:33 PM

To: 'CDT General developers list.'
Subject: Re: [cdt-dev] multicore visualizer plugin

Thinking about it, if we are going to bump the major version of this plugin for sure, then it would be a good idea

to remove the 'internal' word from the package, but keep the code internal ("hidden from all plugin-ins except"),

that way, when we want to make it API we won't have to change the path to the code, which will please

those that may already be using it.

 

WDYT?

 

Marc

 

---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Marc Khouzam
Sent: Tuesday, August 21, 2012 2:02 PM
To: 'CDT General developers list.'
Subject: Re: [cdt-dev] multicore visualizer plugin

My bad.

Bumping the major version is ok with me as long as it does not force Kepler to CDT 9 (as you also mention).

 

Thanks for taking care of this.

 

Marc

 

---

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Cortell John-RAT042
Sent: Tuesday, August 21, 2012 9:31 AM
To: cdt-dev@xxxxxxxxxxx
Subject: [cdt-dev] multicore visualizer plugin

All the packages in this plugin are name-qualified "internal", yet they're marked public ("visible to downstream plug-ins" instead of "hidden from all plug-ins except"). 

Correcting this will require either bumping the version to 2.0 or creating 24 problem filters. Personally I'd like to just bump the major version and disregard this if Kepler becomes 8.2. Anyone have a strong opinion?

John

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev