Re: [cdt-dev] CLI command "hbreak" creates a hardware watchpoint

[Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>]

Thanks.  The patches seem good at first glance.
Please file a bug.

Marc

________________________________
From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Abeer Bagul [abeer4eclipse@xxxxxxxxx]
Sent: January 27, 2011 12:32 AM
To: cdt-dev@xxxxxxxxxxx
Subject: [cdt-dev] CLI command "hbreak" creates a hardware watchpoint

Hi,

When user types the CLI command "hbreak" in the gdb console, gdb inserts a hardware breakpoint. CDT then sends a command "-break-list" to get the updated list of
breakpoints and watchpoints installed in the target. In the reponse, gdb reports the breakpoint inserted thru hbreak as type "hw breakpoint".

Example interaction between CDT and gdb:

[1,293,012,542,777] 177-interpreter-exec console hbreak
[1,293,012,542,792] ~"Hardware assisted breakpoint 4 at 0x60000aa4: file/
build/tree/RD-2010.0-beta4\
_kuma/tools/swtools-MSWin32-x86/xtensa-elf/src/xtos/crt1-sim.S, line 234.\n"
[1,293,012,542,792] 177^done
[1,293,012,542,792] (gdb)
[1,293,012,542,792] 178-break-list
[1,293,012,542,792]
178^done,BreakpointTable={nr_rows="1",nr_cols="6",hdr=[{width="7",alignment="-1"\
,col_name="number",colhdr="Num"},{width="14",alignment="-1",col_name="type",colhdr="Type"},{width="4\
",alignment="-1",col_name="disp",colhdr="Disp"},{width="3",alignment="-1",col_name="enabled",colhdr=\
"Enb"},{width="10",alignment="-1",col_name="addr",colhdr="Address"},{width="40",alignment="2",col_na\
me="what",colhdr="What"}],body=[bkpt={number="4",type="hw
breakpoint",disp="keep",enabled="y",addr="\
0x60000aa4",file="/build/tree/RD-2010.0-beta4_kuma/tools/swtools-MSWin32-x86/xtensa-elf/src/xtos/crt\
1-sim.S",line="234",times="0"}]}
[1,293,012,542,792] (gdb)

In the method, MIBreakpoint.parse(...), any breakpoint whose typename starts with "hw" is treated as a watchpoint. Only those breakpoints whose typename is "hw watchpoint" should be treated as watchpoint.

Have attached two patches, one for the MIBreakpoint class in CDI, and one for the MIBreakpoint class in DSF. Should I file a bug for this?

Thanks
Abeer Bagul
Tensilica India