From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
On Behalf Of John Cortell
Sent: Wednesday, January 05, 2011 10:24 AM
To: CDT General developers list.; CDT General developers list.
Subject: Re: [cdt-dev] Bugzilla 333443
+1. Changing a protected method to public is backwards compatible, both a compile-time and run-time. So, while we are talking about an API change, I think it's a safe one, particularly given that this API is not commonly used.
John
At 08:57 AM 1/5/2011, Rohrbach, Randy wrote:
Content-Language: en-US
Content-Type: multipart/alternative;
boundary="_000_5A4F3DA9DEFC314182FAB44A39A4D23501363EALAMBAcorpadwrsco_"
Folks
For Wind River I am attempting to create a custom importer/exporter for use ine the Memory Browser
and Memory View. In doing so I have found that an API method scrollRenderers in the ImportMemoryDialog
class is incorrectly defined as protected when it should have been public.
This is Bugzilla 333443. I want to change this in cdt 7.0.1 and cdt 8.0. But it is techincally a change
of an existing API and we have generic rules about changing APIs in DOT releases.
So I would like your feedback. My feeling is changing this is not an issue. Apparently no one has tried
to create an independent ( e.g. not conained in the package which contains all the standard importers
and exporters ) or they would have noticed this before. So it looks like I am the first.
Changing it in cdt 8.0 of course is not an issue. All of the standard ones, being rebuilt against this
change in 7.0.1 will take care of them.
We intend a large release in July which will be based on the latest from CDT 7.0.1 and I need to get
my new importer/exporter in to it and I wouild like to NOT create a special branched version just for
this minor change. The method should have been public in the first place since that is it's intended
use.
So again, I am looking for comment for or against this change. I have submitted a patch with the
bugzilla entry. The change is simply "protected" to "public" for that method.
Please let me know what you think.
Thx,
Ranndy
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-dev
