Hi Pawel,
1)
Is the only purpose of the DisassemblyWindowManager to clean up disassembly
windows when their corresponding debuggers
exit?
The other purpose
of DisassemblyWindowManager is to provide a way to open or activate the
corresponding editor - the "openEditor()" method. The global "Open
Disassembly" action will also call this method to open a disassembly window for
the current debug context.
2) To clarify: is the ISourceDisplay adapter still to be provided by the
specific debug model and is the implementation expected to call
DissassemblyWindowManager.openEditor()?
Yes, the ISourceDisplay adapter still should be implemented. But we can provide an abstract class that user can
extend. I actually mention it in the proposal
:)
As I
said it's a very simple part, but it is completely independent. If we
add an extension point to register a disassembly editor with it, it can be
used with Tony's implementation, for example.
Regards,
Mikhail
PS
I'll summarize and put all feed back on wiki.
Thanks Mikhail,
Thank you for the update, I only have a couple of
questions about the proposal so far:
1) Is the only purpose of the
DisassemblyWindowManager to clean up disassembly windows when their
corresponding debuggers exit?
2) To clarify: is the ISourceDisplay adapter
still to be provided by the specific debug model and is the implementation
expected to call
DissassemblyWindowManager.openEditor()?
Thanks
Pawel
P.S. If
you prefer you can just add the answers to the Wiki.
Mikhail
Khodjaiants wrote:
Hi,
Currently I am working on the document that describes
the viewer proposals and trying to prototype it at the same time (or
vice versa I should say). I'll try to post it as soon as
possible.
Regards,
Mikhail
Khodjaiants
ARM
Limited
--
IMPORTANT NOTICE: The contents of this
email and any attachments are confidential and may also be privileged. If you
are not the intended recipient, please notify the sender immediately and do
not disclose the contents to any other person, use it for any purpose, or
store or copy the information in any medium. Thank you.
_______________________________________________
dsdp-dd-dev mailing list
dsdp-dd-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-dd-dev