Re: [cdt-dev] 1.0.1 Binaries and Editor Problem

[Chris Songer <songer@xxxxxxxxxxxxx>]

Hi!

While I appreciate the pointer to addr2line, I tend to prefer to suspect
the things that my group is responsible for rather than heading off and
blaming the tools guys here. They have also had a product out for 4
years, so I tend to be wrong alot when I go looking for them to explain
something.

At the moment I'm looking with a bit of suspicion at the
following:

public
String lineInfo() throws IOException {
if ( line == null ) {
if ( addr2line == null )
addr2line = new Addr2line(file);
line = addr2line.getLine(st_value + 19);
func = addr2line.getFunction(st_value + 19);
}
return line;
}

Somehow those + 19's look a little odd to me, especially since removing them puts the line location spot on. I just can't quite figure where 19 came from in the first place. 

I'll try to get a patch together for the other stuff at some point.

Thanks!
-Chris

At 09:49 AM 3/10/2003 -0500, Alain Magloire wrote:
> > 
> > 
> > Hi,
> > 
> > The following is from 1.0.1. Do you all care?
>
> Yes always.
>
> > Is knowing about it enough or do you want the patch?
> > (Patches are non-trivial for me to product 
> > unfortunately, but I'm willing to take the time if needed. Private email is 
> > fine.
>
> File a PR, we'll take a look.  But if you already have a patch it is welcome(attach to
> the PR).
>
> FYI: Elf does not come up with line numbers, line infos are in the the debug
> format and Runtime.getRuntime().exec("addr2line ..."); is use by the Elf parser
> to retrieve it.  We are working on a basic STABS debug format parser to remove
> the addr2line on the next revision and maybe DWARF-2.
>
> > 
> > >Change 62507 by songer@songer_clea on 2003/03/09 19:25:59
> > >
> > >         First level fix for binary object selection.
> > >
> > >         To go the CView and select main() under the source file and then 
> > > under a built binary. In one case (the source file) you go to the file 
> > > and line. In the other case, it just brings up the file and selects the 
> > > first line. This is the first fix for this behavior. It's not precise, 
> > > there's something screwy about the lines that their elf parser is coming 
> > > up with, but it's at least close.
> > >
> > >         There were actually two bugs here. First, information was being 
> > > thrown away in the translation of ISymbol->IFunction. That's the 
> > > BinaryInfo change. Next the CEditor did not deal properly with 
> > > ISourceRanges that had only line information. That's been corrected as well.
> > >
> > >Affected files ...
> > >
> > >... 
> > >//depot/other/xide/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/model/BinaryInfo.java#4 
> > >edit
> > >... 
> > >//depot/other/xide/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/CEditor.java#4 
> > >edit
> > 
> > Thanks!
> > -Chris
> > songer@xxxxxxxxxxxxx
> > 
> > _______________________________________________
> > cdt-dev mailing list
> > cdt-dev@xxxxxxxxxxx
> > http://dev.eclipse.org/mailman/listinfo/cdt-dev
> > 
>
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/cdt-dev