Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cargotracker-dev] (Review/approve PR)
  • From: Gilbert Kwan <gkwan@xxxxxxxxxx>
  • Date: Wed, 7 Sep 2022 22:10:59 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ca.ibm.com; dmarc=pass action=none header.from=ca.ibm.com; dkim=pass header.d=ca.ibm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N5N3dUQ7vxXgVe/Y3vj+i4DweBfLs5Km8nclGonvop0=; b=d4c02oJSaCo4/ptrvOseHwicvu1IZ2WHZqNbAsSsRlkDlWm2gBPF7pSQMYdKLtv4gBn8p3SQAVIfFVKpzX79gIGuKYJ2S4Ee4u0FIK2gkl6A8ZM1gGLDS181lZTaDjXq/7P4SRNtf1YVUsXv+WorH3tlCdikMNlUKrdTkCcfZn2wi+vJo44gZS+G5TGDm+d3Y5wLoquqpTXK73ouX8KK/00ay/f59yvzxL/txnU5le44JRm50iWeCuyrXA74xG2JV87OWkrdRgBg1L7/pUr/tonuX9B09e1uGChSaqYEMWJmektVRHyJPUEbr9i01fdxLLcxZa6JdJbUJh7t16SWHQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BXGzTbt1HKB/qPDpasYyL/sHYOjU2cf6eMdqX7A3XQ78eloS9MWgTk9DqcdvpFzCBl9uIFjhSaU0GjP4NL+SYh6JBJHF2VqG+Dduo1dQFYLjL16nZCTJU1jC68rqewzE8+md6MO7JTVEf/cpA2mKBHkAcXZGuPKDQ1kk6+W+oF5hu3eb4F7DVa60LBS/SbStTgC+JQFpfCiI9t6ictA+VxgG4dR68aMEZgq0KibGPAFePjV+jJLeC49e5cryXPp/HhJDC0FaL71+aruCLBkkZ4OezABMNWADAbruPIDvTa8neGCJPvO8h8VWKKzI+Unx2JsjChZkM1H74PulG6OYKg==
  • Delivered-to: cargotracker-dev@xxxxxxxxxxx
  • List-archive: <https://dev.eclipse.org/mailman/private/cargotracker-dev/>
  • List-help: <mailto:cargotracker-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://dev.eclipse.org/mailman/listinfo/cargotracker-dev>, <mailto:cargotracker-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://dev.eclipse.org/mailman/options/cargotracker-dev>, <mailto:cargotracker-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHYwrm3hnZ9Pz1vK0uCrC52eK/xuK3UUe9hgAAJG4CAAAAiFYAAEd0AgAAFxO0=
  • Thread-topic: [EXTERNAL] Re: [cargotracker-dev] (Review/approve PR)

Simply speaking, Mojarra uses <h:body>…</h:body>

and MyFaces uses <body><f:view>…</f:view></body> in the xhtml files. Mojarra and MyFaces cannot handle both syntax and cause warnings. Also, if set javax.faces.PROJECT_STAGE=Development, MyFaces generates warnings.  (see the changes for those 3 files in my PR #231.)

 

I just tried the Payara with Mojarra and updated xhtml to use <body>…</body> I got "Warning: This page calls for XML namespace declared with prefix br but no taglibrary exists for that namespace." See the attached “Screen Shot Mojarra.png”  screenshot.

 

I also just tried the Liberty with MyFaces and updated xhtml to use <h:body>…</h:body> and set javax.faces.PROJECT_STAGE=Development, I got warnings on the command line console.

 

I am not sure any common syntax that both can support. I doubt there is because Chanun spent a lot of time on this issue and have no better solution.

 

Thanks

Gilbert 

 

 

 

From: cargotracker-dev <cargotracker-dev-bounces@xxxxxxxxxxx> on behalf of reza_rahman@xxxxxxxxx <reza_rahman@xxxxxxxxx>
Date: Wednesday, September 7, 2022 at 4:34 PM
To: cargotracker developer discussions <cargotracker-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [cargotracker-dev] (Review/approve PR)

What specifically was the original issue with MyFaces and what is the current issue with Mojarra? Can a code change be made to the application to support both Mojarra and MyFaces? From: ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍

ZjQcmQRYFpfptBannerStart

This Message Is From an External Sender

This message came from outside your organization.

ZjQcmQRYFpfptBannerEnd

What specifically was the original issue with MyFaces and what is the current issue with Mojarra? Can a code change be made to the application to support both Mojarra and MyFaces?

 

From: cargotracker-dev <cargotracker-dev-bounces@xxxxxxxxxxx> on behalf of Gilbert Kwan <gkwan@xxxxxxxxxx>
Sent: Wednesday, September 7, 2022 3:39 PM
To: cargotracker developer discussions <cargotracker-dev@xxxxxxxxxxx>
Subject: Re: [cargotracker-dev] (Review/approve PR)

 

The current code from the master works with Payara but not Liberty. The current code from the liberty-experimental branch works with Liberty but not Payara. The change is to narrow down the gap between Payara and Liberty. Eventually, we want that the master branch can carry the Liberty profile, and both Payara and Liberty work well with the same code.

 

Thanks

Gilbert

 

 

From: cargotracker-dev <cargotracker-dev-bounces@xxxxxxxxxxx> on behalf of reza_rahman@xxxxxxxxx <reza_rahman@xxxxxxxxx>
Date: Wednesday, September 7, 2022 at 3:30 PM
To: cargotracker developer discussions <cargotracker-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [cargotracker-dev] (Review/approve PR)

Does the current code work with Payara and Liberty? If so, why is the change needed at all? From: cargotracker-dev <cargotracker-dev-bounces@ eclipse. org> on behalf of Gilbert Kwan <gkwan@ ca. ibm. com> ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍

ZjQcmQRYFpfptBannerStart

This Message Is From an External Sender

This message came from outside your organization.

ZjQcmQRYFpfptBannerEnd

Does the current code work with Payara and Liberty? If so, why is the change needed at all?

 

From: cargotracker-dev <cargotracker-dev-bounces@xxxxxxxxxxx> on behalf of Gilbert Kwan <gkwan@xxxxxxxxxx>
Sent: Wednesday, September 7, 2022 3:26 PM
To: cargotracker developer discussions <cargotracker-dev@xxxxxxxxxxx>
Subject: Re: [cargotracker-dev] (Review/approve PR)

 

Hi Reza,

 

In my understanding from Chanun, there is a JSF implementation difference between Payara and Liberty. Payara is using Mojarra, and Liberty is using MyFaces. Chanun updated the following 3 files on the liberty-experimental branch that are favourite for MyFaces, so that Liberty does not show any warnings.

  1. src/main/webapp/WEB-INF/templates/common/admin.xhtml
  2. src/main/webapp/WEB-INF/templates/common/public.xhtml
  3. src/main/webapp/WEB-INF/web.xml


I cannot judge that the difference is MyFaces bug or Mojarra bug. I don’t see Payara or Liberty will change their implementation. To avoid the difference, Liberty can use Mojarra with the jsfContainer feature. That why I submitted the PR #231 that restores the above 3 files to original (same as master branch) and make Liberty to use Mojarra.

 

Hope it can clarify what the changes are.

 

Thanks

Gilbert

 

From: cargotracker-dev <cargotracker-dev-bounces@xxxxxxxxxxx> on behalf of reza_rahman@xxxxxxxxx <reza_rahman@xxxxxxxxx>
Date: Wednesday, September 7, 2022 at 8:59 AM
To: cargotracker developer discussions <cargotracker-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [cargotracker-dev] (Review/approve PR)

I looked at it, but honestly I am having trouble understanding the changes. One of the goals as an official Jakarta EE project is to highlight standards based implementation neutrality. Why is it necessary to switch to Mojarra? Are we running

ZjQcmQRYFpfptBannerStart

This Message Is From an External Sender

This message came from outside your organization.

ZjQcmQRYFpfptBannerEnd

I looked at it, but honestly I am having trouble understanding the changes. One of the goals as an official Jakarta EE project is to highlight standards based implementation neutrality. Why is it necessary to switch to Mojarra? Are we running into a MyFaces bug or do we have code that isn’t quite standard?

 

From: cargotracker-dev <cargotracker-dev-bounces@xxxxxxxxxxx> on behalf of Gilbert Kwan <gkwan@xxxxxxxxxx>
Sent: Wednesday, September 7, 2022 8:49 AM
To: cargotracker-dev@xxxxxxxxxxx <cargotracker-dev@xxxxxxxxxxx>
Subject: Re: [cargotracker-dev] (Review/approve PR)

 

Hi Reza,

 

Do you have a chance to review and merge my PR https://github.com/eclipse-ee4j/cargotracker/pull/231?

 

Thanks

Gilbert

 

From: Gilbert Kwan <gkwan@xxxxxxxxxx>
Date: Tuesday, August 30, 2022 at 2:12 PM
To: cargotracker-dev@xxxxxxxxxxx <cargotracker-dev@xxxxxxxxxxx>
Subject: FW: [EXTERNAL] [cargotracker-dev] (no subject)

Hi Reza,

 

FYI, I signed the ECA.

 

Thanks

Gilbert

 

From: cargotracker-dev <cargotracker-dev-bounces@xxxxxxxxxxx> on behalf of Gilbert Kwan <gkwan@xxxxxxxxxx>
Date: Friday, August 26, 2022 at 1:06 PM
To: cargotracker-dev@xxxxxxxxxxx <cargotracker-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] [cargotracker-dev] (no subject)

Hi Reza, I continue Chanun work. I just submitted a new PR to liberty-experimental with some updates, hoping that it can be merged soon. Enable Open Liberty to use jsfContainer feature and Mojarra library ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍

ZjQcmQRYFpfptBannerStart

This Message Is From an External Sender

This message came from outside your organization.

ZjQcmQRYFpfptBannerEnd

Hi Reza,

 

I continue Chanun work. I just submitted a new PR to liberty-experimental with some updates, hoping that it can be merged soon.

  1. Enable Open Liberty to use jsfContainer feature and Mojarra library
  2. Restore 2 xhtml and web.xml files to original

 

Thanks

Gilbert Kwan

 

 

Attachment: Screen Shot Mojarra.png
Description: Screen Shot Mojarra.png

Back to the top