[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [buckminster-dev] Hudson plugin and provisioning
|
Hi Daniel,
please see comments inline.
* Parsing the vmargs does not work. The loop in the batch file splits
-Dbuckminster.output.root=D:\hudson in two seperate args, omitting the '=':
"...\bin\java.exe" -Dbuckminster.output.root D:\hudson ...
The same happens when I copy the original command line to a "DOS
Box". If I add "" around the -D args, it works:
"...\buckminster.bat" ... -vmargs "-Dbuckminster.output.root=D:\hudson"
This might depend on the windows version being used, I don't know.
Yes, I've noticed that unfortunately. See here for further references:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=287575
My Windows Slave is a plain 32 bit XP, the reason it worked for me is
something different:
My Windows Slave contained spaces in the paths (because I wanted to test
it well :P). Because of these spaces all arguments got quoted with ""
and that's why the bug didn't occur to me.
Yesterday I committed a fix for that. Instead of the buckminster(.bat)
the plugin uses the equinox launcher again. Version 1.0.2 has been
released yesterday and is hopefully available soon. Sorry for the
trouble and thank you for the feedback.
* The batch files (director/buckminster) have trouble when being
installed in a directory with blanks (it's them again... ;)). But
there's nothing your plugin can do about that. I'll see if I can find an
Eclipse bug for this or file a new one. It's this for statement that
does not work if %EXE_DIR% contains blanks:
for /f "delims= tokens=1" %%c in ('dir /B /S /OD
%EXE_DIR%\plugins\org.eclipse.equinox.launcher_*.jar') do set
EQUINOXJAR=%%c
This works:
for /f "delims= tokens=1" %%c in ('dir /B /S /OD
"%EXE_DIR%\plugins\org.eclipse.equinox.launcher_*.jar"') do set
EQUINOXJAR=%%c
I noticed that a while ago and already fixed it in TRUNK:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=303262
https://bugs.eclipse.org/bugs/show_bug.cgi?id=307978
Best regards,
Johannes
