Summary
Fix Bugzilla bug 152951(partly)-Remove the unnecessary calling
ColorUtil.parserColor by calling PropertyHandle.getIntValue directly as Model's
suggestion
Bugzilla Bug (s) Resolved 152951
Description
Remove the unnecessary calling ColorUtil.parserColor by calling
PropertyHandle.getIntValue directly as Model's suggestion.
Totally GUI has 4 places involved in this revision
1.Color attributes in BaseBorder and are define as "int" type and be
assigned with int value in ReportElementEditPart. Correspondingly,
"drawBorder" method in Line Border and SectionBorder changes the
color parameter as "int" type.
2."getForgroudColor" and "getBackgroudColor" method in
DesignElmentHandleAdapter are modified to obtain color value by calling
PropertyHandle.getIntValue directly.
3.Modified to use PropertyHandle.getIntValue in MasterPageEditPart and
ReportDesignEditPart, and modified setBackgroudColor method in
ReportDesignMarginBorder.
4.Modified to use PropertyHandle.getIntValue in TableGridLayer.
Tests Description
Manual test and code review.
Notes to Build Team
Notes to Developers
Notes to QA
Notes to Documentation
Files Added
Files Edited
/org.eclipse.birt.report.designer.core/src/org/eclipse/birt/report/designer/core/model/DesignElementHandleAdapter.java
/org.eclipse.birt.report.designer.ui/src/org/eclipse/birt/report/designer/internal/ui/editors/schematic/border/BaseBorder.java
/org.eclipse.birt.report.designer.ui/src/org/eclipse/birt/report/designer/internal/ui/editors/schematic/border/LineBorder.java
/org.eclipse.birt.report.designer.ui/src/org/eclipse/birt/report/designer/internal/ui/editors/schematic/border/ReportDesignMarginBorder.java
/org.eclipse.birt.report.designer.ui/src/org/eclipse/birt/report/designer/internal/ui/editors/schematic/border/SectionBorder.java
/org.eclipse.birt.report.designer.ui/src/org/eclipse/birt/report/designer/internal/ui/editors/schematic/editparts/MasterPageEditPart.java
/org.eclipse.birt.report.designer.ui/src/org/eclipse/birt/report/designer/internal/ui/editors/schematic/editparts/ReportDesignEditPart.java
/org.eclipse.birt.report.designer.ui/src/org/eclipse/birt/report/designer/internal/ui/editors/schematic/editparts/ReportElementEditPart.java
/org.eclipse.birt.report.designer.ui/src/org/eclipse/birt/report/designer/internal/ui/editors/schematic/layer/TableGridLayer.java
Hongchang Lin
