[birt-dev] Checkin: Fix bug 153507: Bogus error when bad data set column

["Xiaofeng Zhang" <xiaofeng.zhang@xxxxxxxxxxx>]

- Summary:

Fix bug 153507

- Bugzilla Bug (s) Resolved:
Fix bug 153507: Bogus error when bad data set column referenced in group key

 

- Description:
In original grouping algorithm Dte creates a temporary computed column using JS _expression_ for every group with interval. In some cases Rhino can’t give clear error message for the error in  this computed column.  As Gary’s suggestion  a class GroupComputedColumn is added to replace the ComputedColumn with complex JS _expression_.  The class is sub class of ComputedColumn and contains a Calculator which can do the work of JS _expression_. New algorithm can give exact error message and have better performance.

.

- Tests Description:
 Junit Test

 

- Notes to Build Team:
N/A

- Notes to Developers:
N/A

- Notes to QA:  

N/A

 

- Notes to Documentation:  
N/A

 

- Files Edited:

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/QueryExecutor.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/ComputedColumnHelper.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/i18n/Messages.properties

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/i18n/ResourceConstants.java

 

/org.eclipse.birt.data/test/org/eclipse/birt/data/engine/AllTests.java

/org.eclipse.birt.data/test/org/eclipse/birt/data/engine/binding/golden/GroupOnRowTest.testGroupOnWeek1.txt

/org.eclipse.birt.data/test/org/eclipse/birt/data/engine/binding/golden/GroupOnRowTest.testGroupOnWeek.txt

- Files Added:

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/GroupComputedColumn.java

 

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/GroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/DayGroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/HourGroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/NumericGroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/GroupCalculatorFactory.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/QuarterGroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/MonthGroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/YearGroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/SecondGroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/StringGroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/MinuteGroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/ICalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/DateGroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/WeekGroupCalculator.java

/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/group/DateTimeUtil.java 

 

 - Files Deleted:

 /org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/ExpressionUtil.java

/org.eclipse.birt.data/test/org/eclipse/birt/data/engine/impl/ExpressionUtilTest.java