Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [automotive-pmc] [EXTERNAL] Fwd: [tractusx-dev] Contributions above 1.000 lines of code

Hi Steven,


thanks for the question. For a project content IP check you have to open a ticket at the EF IPLab , the EF IP Team then reviews the content:
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/new 


-> choose Template: vet-project


It is in the responsibilities of the committer to request the reviews. As I know there is no automation.


Best regards
Angelika





On 18.06.24 21:00, Steven Hartley wrote:
Angelika (et. al.),
We frequently have contributions in Eclipse-uProtocol from non-committers that are >1K and was unaware of this requirement. Could this check (of 1K lines of code) not become a mandatory CI workflow for all PRs like the ECA check? Additionally, could project leads and/or committers, have access to the tools that run these scans so we can either manually check or incorporate them into the CI workflows?

Thanks.

Steven.

From: automotive-pmc <automotive-pmc-bounces@xxxxxxxxxxx> on behalf of Angelika Wittek via automotive-pmc <automotive-pmc@xxxxxxxxxxx>
Sent: Monday, June 17, 2024 11:21 AM
To: Automotive PMC discussions <automotive-pmc@xxxxxxxxxxx>
Cc: Angelika Wittek <angelika.wittek@xxxxxxxxxx>
Subject: [EXTERNAL] [automotive-pmc] Fwd: [tractusx-dev] Contributions above 1.000 lines of code
 

ATTENTION: This email originated from outside of GM.

 




-------- Forwarded Message --------
Subject: [tractusx-dev] Contributions above 1.000 lines of code
Date: Mon, 17 Jun 2024 14:34:34 +0000
From: Kiermayer, Siegfried via tractusx-dev <tractusx-dev@xxxxxxxxxxx>
Reply-To: tractusx developer discussions <tractusx-dev@xxxxxxxxxxx>
To: tractusx-dev@xxxxxxxxxxx <tractusx-dev@xxxxxxxxxxx>
CC: Kiermayer, Siegfried <siegfried.kiermayer@xxxxxxx>


Hello community,

 

I would like to make all of us aware that we do have a high responsibility for contributions which come from outside.

 

Outside means from people who are not committers which can include friends, family, and co-worker.

 

The Eclipse Handbook is very clear about contributions from outside with changes more than 1.000 lines of code:  https://www.eclipse.org/projects/handbook/#ip-project-content

 

“Further investigation is required when any of the following conditions are met:

  • The content has been copied, or is based on content that has been copied (that is, the content was not 100% authored by the submitting contributor);
  • The licence terms of the content are other than the terms of the project license;
  • The content contains cryptography; or
  • The content contains more than 1,000 lines of content (including documentation, code, configuration files, and other forms of source code).

When further investigation is required, a project committer must engage with the IP Team to request their review before the contribution is pushed/merged.”

 

Even changes to documentation and configuration files are already included in the eclipse handbook. Do not assume that ‘just because it was this type of change or that type of change’ that you don’t need to create a ticket with the IP Team.

 

The benefit of committers and committers only:


“Contributions made by Eclipse committers do not require review by the Eclipse IP Team and can be pushed directly into a project repository. Notwithstanding project-specific rules, project committers can push their own content directly into project repositories. While content produced by other Eclipse committers does not require review by the Eclipse IP Team, it must still be accepted by project committers”

 

The most critical thing, we as indirect representatives of the Eclipse Foundation, is to make sure that we do our due diligence regarding IP Checks. Do not think about this as optional.

 

Thanks,

 

Sigi

 

 



Nothing in this message is intended to constitute an electronic signature unless a specific statement to the contrary is included in this message.

Confidentiality Note: This message is intended only for the person or entity to which it is addressed. It may contain confidential and/or privileged material. Any review, transmission, dissemination or other use, or taking of any action in reliance upon this message by persons or entities other than the intended recipient is prohibited and may be unlawful. If you received this message in error, please contact the sender and delete it from your computer.

Back to the top