Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[automotive-pmc] Fwd: [tractusx-dev] Committer Election for Lucas Capellino on Eclipse Tractus-X has started

FYI



-------- Forwarded Message --------
Subject: Re: [tractusx-dev] Committer Election for Lucas Capellino on Eclipse Tractus-X has started
Date: Thu, 2 May 2024 13:58:02 +0200
From: Paul Latzelsperger via tractusx-dev <tractusx-dev@xxxxxxxxxxx>
Reply-To: tractusx developer discussions <tractusx-dev@xxxxxxxxxxx>
To: tractusx developer discussions <tractusx-dev@xxxxxxxxxxx>
CC: Paul Latzelsperger <paul.latzelsperger@xxxxxxxxxxxxx>


Hey all,

Sorry for the spam, the voting page doesn't do formatting properly, so let me elaborate on my -1 a bit:

Lacking personal experience with Lucas I can only go by what was presented in the nomination. To me most PRs are of somewhat reasonable size (except one or two that seem a bit unfocused), but I obviously did not look at the PRs in terms of code quality. I did however notice that most PRs don't have a ton of test code which makes me question the &quot;high software quality standards&quot; statement. I am a stickler for tests, so that just might be me.

There are other issues I see, specifically:
  • many PRs have no description or reviews on them
  • some PRs seem to have been created by someone else, but are still listed. not sure how they are relevant.
  • PRs don't have any labels, linked issues or other metadata on them, which (to me) would demonstrate proper OSS procedures.
  • many PRs have merge commits and commits from other contributors on them. To me that indicates poor PR hygiene and focus.
  • I don't know what &quot;reviews and harmonization&quot; means, because this bullet point only links the repos, so I'm having a hard time  understanding the contributions there.
Overall I see considerable room for improvement in terms of OSS procedures and transparency, and I am very sorry to say that as things stand I cannot +1 this for the reasons stated above. 

Best,
Paul

On Thu, May 2, 2024 at 11:51 AM sebastian.bezold--- via tractusx-dev <tractusx-dev@xxxxxxxxxxx> wrote:

Hi all,

 

first of all thank you for this proposal. It is good to see continuous interest in becoming Eclipse Tractus-X committer.

I want to highlight some thinks, that I find odd on this proposal though:

 

In general, I find it hard to see the actual contributions made by Lucas. A lot of PRs contain commits done by multiple people, like https://github.com/eclipse-tractusx/traceability-foss/pull/751 for example.
There is even one without any contributions: https://github.com/eclipse-tractusx/traceability-foss/pull/826 This one is especially odd, since the commits + review (LGTM) is done by the same person. Only the PR was created by Lucas.

 

I also cannot really see the “review and harmonization” effort. Could you maybe make this a bit more tangible?

 

Cheers

Sebastian

 

Von: tractusx-dev <tractusx-dev-bounces@xxxxxxxxxxx> im Auftrag von emo--- via tractusx-dev <tractusx-dev@xxxxxxxxxxx>
Datum: Donnerstag, 2. Mai 2024 um 10:39
An: Eclipse Tractus-X Dev List <tractusx-dev@xxxxxxxxxxx>
Cc: emo@xxxxxxxxxxxxxxxxxxxxxx <emo@xxxxxxxxxxxxxxxxxxxxxx>, automotive-pmc PMC List <automotive-pmc@xxxxxxxxxxx>, Eclipse Management Organization <emo@xxxxxxxxxxx>
Betreff: [tractusx-dev] Committer Election for Lucas Capellino on Eclipse Tractus-X has started

[**EXTERNAL E-MAIL**]

A committer election for Lucas Capellino on project Eclipse Tractus-X
(automotive.tractusx) was started by Martin Kanal with this criteria:

Hello Tractus-X Community/Committer,

I would like to nominate Lucas Capellino (GitHub handle
https://github.com/ds-lcapellino) to become a committer in the Eclipse
Tractus-X project. Lucas has contributed documentation to multiple Tractus-X
repositories. He maintains the Trace-X FOSS product in
eclipse-tractusx.github.io.

He is an experienced developer who has shown expertise in backend development
and good knowledge of software architecture. His notable contributions to
various projects showcase his skills, emphasizing transparency and a strong
commitment to maintaining high software quality standards.

   Some of his contributions are listed below.

He contributed to various Tractus-X repositories:

Trace-X FOSS
- https://github.com/eclipse-tractusx/traceability-foss/pull/632
- https://github.com/eclipse-tractusx/traceability-foss/pull/751

IRS
- https://github.com/eclipse-tractusx/item-relationship-service/pull/467
- https://github.com/eclipse-tractusx/item-relationship-service/pull/451

Portal
- https://github.com/catenax-ng/tx-portal-frontend/pull/426

Testdata Provider
- https://github.com/eclipse-tractusx/testdata-provider/pull/3


Lucas has shown that he understood the concepts of the Tractus-X Release
Guidelines and is continuously coming up with solutions on how to
implement/optimize them:
https://github.com/eclipse-tractusx/traceability-foss/pull/826
- https://github.com/eclipse-tractusx/traceability-foss/pull/833


Here is an example of an issue he opened, in case he needed help from SIGs:
- https://github.com/eclipse-tractusx/sig-infra/issues/455

It is recommendable to include

Other Community contributions:

- Reviews and harmonization (i.e.
https://github.com/eclipse-tractusx/item-relationship-service
https://github.com/eclipse-tractusx/traceability-foss/)
- Advocacy and outreach
- Q&A in the matrix channel
https://matrix.to/#/#tractusx-irs:matrix.eclipse.org
https://matrix.to/#/#tractusx-trace-x:matrix.eclipse.org

It is my pleasure to nominate ds-lcapellino as a committer on Eclipse
Tractus-X.

Eclipse Tractus-X project committers can click the election link below to
vote.

Election:
https://projects.eclipse.org/projects/automotive.tractusx/elections/election-lucas-capellino-committer-eclipse-tractus-x

Project: https://projects.eclipse.org/projects/automotive.tractusx

_______________________________________________
tractusx-dev mailing list
tractusx-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://accounts.eclipse.org


If you are not the addressee, please inform us immediately that you have received this e-mail by mistake, and delete it. We thank you for your support.
_______________________________________________
tractusx-dev mailing list
tractusx-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://accounts.eclipse.org
_______________________________________________
tractusx-dev mailing list
tractusx-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://accounts.eclipse.org

Back to the top