[aspectj-dev] fixed addProjectTask problem

["Mik Kersten" <beatmik@xxxxxxx>]

I investigated the high priority bug of build config file errors not showing
up in AJDT.  The problem turned out to be a bit more serious, as it looks
like AJDT has always failed to show all messages given to
org.aspectj.ajde.TaskListManager.addProjectTask(..).  In other words
messages not associated with a single source file.  You may ask yourself why
problems parsing a config file are not associated with that file.  That's a
good question, and a lower priority problem that needs addressing later (it
will always be clear which file was used for the build).

I've fixed this bug by changing
org.eclipse.ajdt.internal.ui.ajde.CompilerMonitor.showMessages() to handle
messages with a null source location, and add those as markers on the
project.   The fix uses
org.eclipse.ajdt.internal.builder.Builder.getLastBuildTarget() to get the
current project.  Could someone verify that this is the best way?

On the AspectJ side, I changed the build config parser error text messages
to make it clear where those errors were coming from
(org.aspectj.util.ConfigParser and org.aspectj.ajdt.ajcBuildArgParser).  

We need to cover messages in AJDT with unit tests.  In AJDE/AJBrowser this
is currently done by running a test that has the tester visually verify that
a message showed up, and click the appropriate button (blah).  Hopefully in
AJDT we can query the task list view for its items and compare.

Mik

--
http://kerstens.org/mik