[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [4diac-dev] Some minor improvements
|
Hi,
no problem. As said in a previous email. haveing this better is definitly a win for 4diac. See some comments below:
> * https://git.eclipse.org/r/#/c/104435/This adds a bunch more patterns to the gitignore. For me this resolves the issue that "git status" lists a bunch of "changed" files after a cmake build. Please do doublecheck I didn't list anything which should be tracked.
I don't see an issue here. A pattern that we are currently starting to apply is to have our build directory is to have the build directory outside of forte source code. This is espeically intersting in a setup where you have also some non forte hosted modules you like to add to forte coming from different repos. Then you can specifiy in cmake an external modules directory where our build system will also look if it finds modules (e.g., a special Fb library).
> * https://git.eclipse.org/r/#/c/104434/[https://git.eclipse.org/r/#/c/104434/]This change improves the bootfile loader logic as described in the commit message. The idea behind that is to allow failing when the file is expected but missing and allows to completely disable the loader.
As i finally posted at this bug [1] the bootloader code should be refactored into an own class. Espeically with the code that you added the loader gets longer and longer and less readable.
cheers,
Alois
[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=514887
